-
Notifications
You must be signed in to change notification settings - Fork 273
Add subclass based method for inference w/ MXFP8 #2132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2132
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
added a commit
that referenced
this pull request
Apr 25, 2025
stack-info: PR: #2132, branch: drisspg/stack/50
93067f0
to
34fa252
Compare
jerryzh168
reviewed
Apr 25, 2025
jerryzh168
reviewed
Apr 25, 2025
Sorry, this should be a draft still, I am just dumping all my commits for now |
Closed
Closed
drisspg
added a commit
that referenced
this pull request
May 2, 2025
stack-info: PR: #2132, branch: drisspg/stack/50
drisspg
commented
May 3, 2025
1ef5526
to
7147243
Compare
drisspg
added a commit
that referenced
this pull request
May 8, 2025
stack-info: PR: #2132, branch: drisspg/stack/50
drisspg
added a commit
that referenced
this pull request
May 8, 2025
stack-info: PR: #2132, branch: drisspg/stack/50
drisspg
added a commit
that referenced
this pull request
May 8, 2025
stack-info: PR: #2132, branch: drisspg/stack/50
drisspg
added a commit
that referenced
this pull request
May 8, 2025
stack-info: PR: #2132, branch: drisspg/stack/50
vkuzo
reviewed
May 9, 2025
vkuzo
reviewed
May 9, 2025
vkuzo
reviewed
May 9, 2025
vkuzo
reviewed
May 9, 2025
vkuzo
reviewed
May 9, 2025
vkuzo
approved these changes
May 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg!
stack-info: PR: #2132, branch: drisspg/stack/50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
quantize
topic: new feature
Use this tag if this PR adds a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
add subclass based method for inference
Perf comparisons
Micro
https://fburl.com/whh557d1
I am seeing extra overhead then expected
Macro
Runnng
Running against MXFP8:
Trace NonQuant:
https://fburl.com/sput3bmn
Trace Quant:
https://fburl.com/0pgmyrge