-
Notifications
You must be signed in to change notification settings - Fork 273
Add a triton kernel for swizziling #2168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stack-info: PR: #2168, branch: drisspg/stack/53
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2168
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f69bd4e with merge base 8369268 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
stack-info: PR: #2168, branch: drisspg/stack/53
stack-info: PR: #2168, branch: drisspg/stack/53
stack-info: PR: #2168, branch: drisspg/stack/53
stack-info: PR: #2168, branch: drisspg/stack/53
All good now: =========================================================================================== warnings summary ===========================================================================================
test/prototype/mx_formats/test_mx_linear.py::test_linear_compile[False-False-mxfp8_emulated-hp_dtype0]
/home/drisspg/meta/pytorch/torch/_inductor/compile_fx.py:246: UserWarning: TensorFloat32 tensor cores for float32 matrix multiplication available but not enabled. Consider setting `torch.set_float32_matmul_precision('high')` for better performance.
warnings.warn(
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================================================================== 257 passed, 63 skipped, 1 warning in 116.63s (0:01:56) ========================================================================
❯ TLDR: dont use reorder=True w/ tl.reshape |
stack-info: PR: #2168, branch: drisspg/stack/53
stack-info: PR: #2168, branch: drisspg/stack/53
stack-info: PR: #2168, branch: drisspg/stack/53
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
05171d0
to
809a3db
Compare
stack-info: PR: #2168, branch: drisspg/stack/53
Stacked PRs:
LLama 70b feed forward w/ this kernel:
https://fburl.com/125yv8hh
~632 µs
without:
https://fburl.com/a21gwjmc
~ 801 µs
BF16 for reference:
https://fburl.com/2lgn9xkx
VLLM
Once I figure out why this isnt' always working, I am getting
Future
We are swizziling the scales for all the weights as well we can shave some micros seconds if we keep around a cached variant