Correct the condition when setting External id #978
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aaronenyeshi , please help to review this pr, thank you. |
|
@aaronenyeshi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@aaronenyeshi merged this pull request in ba4caf6. |
staugust
pushed a commit
to staugust/kineto
that referenced
this pull request
Aug 27, 2024
Summary: The `External id` will be set to op.linkedActivity()->correlationId() if op.linkedActivity() is not nullptr. So in `if` condition we should check if op.linkedActivity()->correlationId() is 0. Pull Request resolved: pytorch#978 Reviewed By: xuzhao9 Differential Revision: D61608345 Pulled By: aaronenyeshi fbshipit-source-id: edc2c121a970756f008cae10a175b1f7066af18c
staugust
pushed a commit
to staugust/kineto
that referenced
this pull request
Aug 27, 2024
Summary: The `External id` will be set to op.linkedActivity()->correlationId() if op.linkedActivity() is not nullptr. So in `if` condition we should check if op.linkedActivity()->correlationId() is 0. Pull Request resolved: pytorch#978 Reviewed By: xuzhao9 Differential Revision: D61608345 Pulled By: aaronenyeshi fbshipit-source-id: edc2c121a970756f008cae10a175b1f7066af18c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
External idwill be set to op.linkedActivity()->correlationId() if op.linkedActivity() is not nullptr. So inifcondition we should check if op.linkedActivity()->correlationId() is 0.