Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add SHA256 checksum for binary uploads to S3 #6172

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[CI] Add SHA256 checksum for binary uploads to S3 #6172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/binary-upload/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ runs:
# shellcheck disable=SC1090
source "${BUILD_ENV_FILE}"

pip install awscli==1.32.18
pip install awscli==1.37.0
yum install -y jq

export AWS_ROLE_ARN="arn:aws:iam::749337293305:role/gha_workflow_nightly_build_wheels"
Expand All @@ -43,5 +43,5 @@ runs:
| jq -r '.value' > "${AWS_WEB_IDENTITY_TOKEN_FILE}"

for pkg in dist/*; do
aws s3 cp "$pkg" "${PYTORCH_S3_BUCKET_PATH}" --acl public-read
aws s3 cp "$pkg" "${PYTORCH_S3_BUCKET_PATH}" --acl public-read --checksum-algorithm SHA256
done
4 changes: 2 additions & 2 deletions .github/workflows/_binary_upload.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,15 @@ jobs:
# shellcheck disable=SC1090
source "${BUILD_ENV_FILE}"

pip install awscli==1.32.18
pip install awscli==1.37.0

AWS_CMD="aws s3 cp --dryrun"
if [[ "${NIGHTLY_OR_TEST:-0}" == "1" ]]; then
AWS_CMD="aws s3 cp"
fi

for pkg in dist/*; do
${AWS_CMD} "$pkg" "${PYTORCH_S3_BUCKET_PATH}" --acl public-read
${AWS_CMD} "$pkg" "${PYTORCH_S3_BUCKET_PATH}" --acl public-read --checksum-algorithm SHA256
done

- name: Upload package to pypi
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update_disabled_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ jobs:
- name: Upload files to s3
if: github.event_name != 'pull_request'
run: |
python3 -mpip install awscli==1.27.69
python3 -mpip install awscli==1.37.0

aws s3 cp disabled-tests-condensed.json s3://ossci-metrics/disabled-tests-condensed.json
aws s3 cp disabled-jobs.json s3://ossci-metrics/disabled-jobs.json
Expand Down
Loading