[CI] Add SHA256 checksum for binary uploads to S3 #6172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
clee2000
reviewed
Jan 15, 2025
This ensures binary uploads to S3 attaches a SHA256 checksum.
abn
force-pushed
the
ci/upload-object-checksum
branch
from
b563325 to
8986f5b
Compare
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jan 22, 2025
Equivalent to pytorch/test-infra#6172 but for pytorch Pull Request resolved: #144887 Approved by: https://github.com/atalman
atalman
added a commit
that referenced
this pull request
Jan 23, 2025
Reverts #6172 Broke download.pytorch.org index. Please see: https://github.com/pytorch/pytorch/actions/runs/12926060185/job/36048291540#step:4:124
atalman
added a commit
that referenced
this pull request
Jan 23, 2025
This to be reverted on Jan 24, 2025 To fix following failure: https://github.com/pytorch/pytorch/actions/runs/12926060185/job/36048291540#step:4:124 Caused by: pytorch/pytorch#144887 and #6172
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jan 31, 2025
Equivalent to pytorch/test-infra#6172 but for pytorch Pull Request resolved: #144887 Approved by: https://github.com/atalman
mori360
pushed a commit
to mori360/pytorch
that referenced
this pull request
Feb 6, 2025
Equivalent to pytorch/test-infra#6172 but for pytorch Pull Request resolved: pytorch#144887 Approved by: https://github.com/atalman
Tytskiy
pushed a commit
to Tytskiy/pytorch
that referenced
this pull request
Feb 18, 2025
Equivalent to pytorch/test-infra#6172 but for pytorch Pull Request resolved: pytorch#144887 Approved by: https://github.com/atalman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures binary uploads to S3 attaches a SHA256 checksum.
I am not familiar with this code base, but from what I can gather the S3 uploads seem to be missing SHA256 for various wheel file URLs. This seem to lead to missing wheel hashes at https://download.pytorch.org/. My guess is that the checksum is not available when it is retrieved when the html is generated.
With this change, it should ensure that the checksum is calculated before upload and attached to the object.
Relates-to: pytorch/pytorch#76557