update vs2022 to fix illegal instruction. - #6968
Merged
Merged
Conversation
|
@xuhancn is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
Contributor
Author
|
@atalman could you please take a look？ |
xuhancn
marked this pull request as ready for review
August 4, 2025 22:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old pinned version
ltsc.17.8will cause an illegal instruction issue, we need to upgrade vs2022 to greater than17.9.3: pytorch/pytorch#145702 (comment)For old pinned version is for nerfstudio-project/nerfstudio#3157, and for cuda 11.8 and 12.1 builds.
nerfstudiofixed issue since CUDA 12.4: Nerfstudio not compile with latest Visual Studio 2022 due to MSC 1950 nerfstudio-project/nerfstudio#3157 (comment).