Skip to content

update vs2022 to fix illegal instruction. #6968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atalman merged 1 commit into from
Aug 6, 2025
Merged

update vs2022 to fix illegal instruction. #6968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions aws/ami/windows/scripts/Installers/Install-VS.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ $VS_VERSION_major = [int] ${env:VS_VERSION}.split(".")[0]

$VS_DOWNLOAD_LINK = "https://aka.ms/vs/$VS_VERSION_major/release/vs_BuildTools.exe"

# Pin to older vs_buildtools version for cuda 11.8 and 12.1 builds
# see issue: https://github.com/nerfstudio-project/nerfstudio/issues/3157
# Select latest LTSC version: 17.12, from https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-history
# The early version which fixed illegal instruction is 17.9.4, from https://github.com/pytorch/pytorch/issues/145702#issuecomment-2863244306
if ( ${env:VS_YEAR} -eq "2022" ) {
$VS_DOWNLOAD_LINK = "https://aka.ms/vs/17/release.ltsc.17.8/vs_buildtools.exe"
$VS_DOWNLOAD_LINK = "https://aka.ms/vs/17/release.ltsc.17.12/vs_buildtools.exe"
}

$COLLECT_DOWNLOAD_LINK = "https://aka.ms/vscollect.exe"
Expand Down