Skip to content

Don't advertise CUDA 13.4 on the getting-started page - #8499

Merged
atalman merged 1 commit into
pytorch:mainfrom
atalman:exclude_cuda134_getting_started
Aug 11, 2026
Merged

Don't advertise CUDA 13.4 on the getting-started page#8499
atalman merged 1 commit into
pytorch:mainfrom
atalman:exclude_cuda134_getting_started

Conversation

@atalman

@atalman atalman commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

update-quick-start-module.yml in pytorch/pytorch.github.io calls generate_binary_build_matrix.yml@main with getting-started: true for linux/windows/macos-arm64 on the nightly and release channels, and publishes the result as the pytorch.org install selector.

Because 13.4 is in CUDA_ARCHES_DICT["nightly"], that bot has started adding a cu134 option — see pytorch/pytorch.github.io#2130, which introduces:

pip3 install --pre torch torchvision --index-url https://download.pytorch.org/whl/nightly/cu134

13.4 is built and validated, but it is not ready to be offered to users, so this gates it out of the getting-started matrix only.

Approach

initialize_globals already accepted a getting_started argument that was never used — this gives it a purpose. The filter follows the existing CUDA_ARCHES_NO_WINDOWS convention immediately above it:

CUDA_ARCHES_NO_GETTING_STARTED = ["13.4"]

To re-enable 13.4 on the page later, drop it from that list — no other change needed.

CUDA_AARCH64_ARCHES is deliberately untouched: the getting-started workflow never requests linux-aarch64, and that list is a module constant with no per-channel dict behind it, so filtering it in place would leak into later calls in the same process.

Test plan

  • python -m tools.tests.test_generate_binary_build_matrix — 11 tests pass.
  • --update-reference-files — no asset changes.
  • Getting-started matrix (--getting-started true), cu134 entry count before -> after, across all six jobs the quick-start workflow runs:
os channel before after
linux nightly 2 0
linux release 0 0
windows nightly / release 0 0
macos-arm64 nightly / release 0 0

The two linux/nightly entries are the wheel + libtorch options #2130 was adding. Windows was already 0 via CUDA_ARCHES_NO_WINDOWS.

  • Non-getting-started matrices are byte-identical (md5) for {linux, linux-aarch64, windows, macos-arm64} x {nightly, test, release} — builds and binary validation are unaffected.
  • Verified the filter does not leak across calls: after a getting_started=True call, a subsequent default call still sees ['12.6', '13.0', '13.2', '13.4'].

Authored with the assistance of Claude Code.

`update-quick-start-module.yml` in pytorch/pytorch.github.io calls
`generate_binary_build_matrix.yml@main` with `getting-started: true` for
linux/windows/macos-arm64 on the nightly and release channels, and publishes
the result as the pytorch.org install selector. Because 13.4 is in
`CUDA_ARCHES_DICT["nightly"]`, that bot has started adding a `cu134` option --
see pytorch/pytorch.github.io#2130, which introduces
`pip3 install --pre torch torchvision --index-url .../nightly/cu134`.

13.4 is built and validated but is not ready to be offered to users, so gate
it out of the getting-started matrix only.

`initialize_globals` already took a `getting_started` argument that was never
used; this gives it a purpose. The filter follows the existing
`CUDA_ARCHES_NO_WINDOWS` convention right above it.

To re-enable 13.4 on the page later, drop it from
`CUDA_ARCHES_NO_GETTING_STARTED` -- no other change needed.

Note `CUDA_AARCH64_ARCHES` is deliberately untouched: the getting-started
workflow never requests `linux-aarch64`, and that list is a module constant
with no per-channel dict behind it, so filtering it in place would leak into
later calls in the same process.

Test plan:
- `python -m tools.tests.test_generate_binary_build_matrix` - 11 tests pass.
- `--update-reference-files` produces no asset changes.
- Getting-started matrix (`--getting-started true`), cu134 entry count,
  before -> after, across all six jobs the quick-start workflow runs:
  - linux/nightly: 2 -> 0   (the wheel + libtorch entries pytorch#2130 was adding)
  - linux/release, windows/*, macos-arm64/*: 0 -> 0 (unchanged)
- Non-getting-started matrices are byte-identical (md5) for
  {linux, linux-aarch64, windows, macos-arm64} x {nightly, test, release},
  so builds and binary validation are unaffected.
- Verified the filter does not leak across calls: after a
  `getting_started=True` call, a subsequent default call still sees
  `['12.6', '13.0', '13.2', '13.4']`.

Authored with the assistance of Claude Code.
@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 11, 2026
@atalman
atalman merged commit 3987ba1 into pytorch:main Aug 11, 2026
85 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants