Don't advertise CUDA 13.4 on the getting-started page - #8499
Merged
Conversation
`update-quick-start-module.yml` in pytorch/pytorch.github.io calls `generate_binary_build_matrix.yml@main` with `getting-started: true` for linux/windows/macos-arm64 on the nightly and release channels, and publishes the result as the pytorch.org install selector. Because 13.4 is in `CUDA_ARCHES_DICT["nightly"]`, that bot has started adding a `cu134` option -- see pytorch/pytorch.github.io#2130, which introduces `pip3 install --pre torch torchvision --index-url .../nightly/cu134`. 13.4 is built and validated but is not ready to be offered to users, so gate it out of the getting-started matrix only. `initialize_globals` already took a `getting_started` argument that was never used; this gives it a purpose. The filter follows the existing `CUDA_ARCHES_NO_WINDOWS` convention right above it. To re-enable 13.4 on the page later, drop it from `CUDA_ARCHES_NO_GETTING_STARTED` -- no other change needed. Note `CUDA_AARCH64_ARCHES` is deliberately untouched: the getting-started workflow never requests `linux-aarch64`, and that list is a module constant with no per-channel dict behind it, so filtering it in place would leak into later calls in the same process. Test plan: - `python -m tools.tests.test_generate_binary_build_matrix` - 11 tests pass. - `--update-reference-files` produces no asset changes. - Getting-started matrix (`--getting-started true`), cu134 entry count, before -> after, across all six jobs the quick-start workflow runs: - linux/nightly: 2 -> 0 (the wheel + libtorch entries pytorch#2130 was adding) - linux/release, windows/*, macos-arm64/*: 0 -> 0 (unchanged) - Non-getting-started matrices are byte-identical (md5) for {linux, linux-aarch64, windows, macos-arm64} x {nightly, test, release}, so builds and binary validation are unaffected. - Verified the filter does not leak across calls: after a `getting_started=True` call, a subsequent default call still sees `['12.6', '13.0', '13.2', '13.4']`. Authored with the assistance of Claude Code.
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
huydhn
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update-quick-start-module.ymlin pytorch/pytorch.github.io callsgenerate_binary_build_matrix.yml@mainwithgetting-started: truefor linux/windows/macos-arm64 on the nightly and release channels, and publishes the result as the pytorch.org install selector.Because 13.4 is in
CUDA_ARCHES_DICT["nightly"], that bot has started adding acu134option — see pytorch/pytorch.github.io#2130, which introduces:13.4 is built and validated, but it is not ready to be offered to users, so this gates it out of the getting-started matrix only.
Approach
initialize_globalsalready accepted agetting_startedargument that was never used — this gives it a purpose. The filter follows the existingCUDA_ARCHES_NO_WINDOWSconvention immediately above it:To re-enable 13.4 on the page later, drop it from that list — no other change needed.
CUDA_AARCH64_ARCHESis deliberately untouched: the getting-started workflow never requestslinux-aarch64, and that list is a module constant with no per-channel dict behind it, so filtering it in place would leak into later calls in the same process.Test plan
python -m tools.tests.test_generate_binary_build_matrix— 11 tests pass.--update-reference-files— no asset changes.--getting-started true),cu134entry count before -> after, across all six jobs the quick-start workflow runs:The two linux/nightly entries are the wheel + libtorch options #2130 was adding. Windows was already 0 via
CUDA_ARCHES_NO_WINDOWS.{linux, linux-aarch64, windows, macos-arm64}x{nightly, test, release}— builds and binary validation are unaffected.getting_started=Truecall, a subsequent default call still sees['12.6', '13.0', '13.2', '13.4'].Authored with the assistance of Claude Code.