lighthouse, manager: remove room support #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
H-Huang
approved these changes
Jan 13, 2025
|
@H-Huang in practice this ended up being too fragile and could end up with two rooms flip-flopping and thus split brain training. Since for LocalSGD the step times can be 40 minutes, in order to prevent that behavior you either need the join timeout extremely long or you need to set min_replicas to always be >=50% of the replicas which isn't feasible in all cases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes previously added room support in #48
This didn't work out in practice as expected and will be instead replaced with "shrink only" quorum support which is a bit easier to reason about and doesn't require absurdly long timeouts.
Test plan: