coordination: expose new low level torchft coordination API #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
d4l3k
force-pushed
the
d4l3k/coordination
branch
from
b4c8807 to
2cf6c4f
Compare
d4l3k
force-pushed
the
d4l3k/coordination
branch
from
2cf6c4f to
f2bd4d4
Compare
|
cc @b0noI |
H-Huang
approved these changes
Feb 18, 2025
| /// store_addr (str): The HTTP address of the store server. | ||
| /// world_size (int): The world size of the replica group. | ||
| /// heartbeat_interval (timedelta): The interval at which heartbeats are sent. | ||
| /// connect_timeout (timedelta): The timeout for connecting to the lighthouse server. |
There was a problem hiding this comment.
just curious, is it the standard in rust for the documentation to be above the struct definition rather than the new method since the parameters for the constructor aren't shown here.
There was a problem hiding this comment.
These comments aren't really standard rust. This format is specifically so pyo3 will pull in the comments so they show up in the Python documentation
Added a screenshot to the test plan so you can see how it renders in sphinx
Sphinx doesn't render __init__ separately by default so it all gets dumped into the class doc string
There was a problem hiding this comment.
cool, thanks for the SS. Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes LighthouseServer, ManagerServer and ManagerClient so power users can directly call them to implement custom fault tolerance strategies.
It also renames some modules (
_torchftfor Rust lib) and methods to indicate which ones are private and subject to change.This does not expose a quorum algorithm currently. The plan is to add a new "simple quorum" interface that allows for custom data to be passed between members instead of the data required by the Manager.
We may also want to expose a pluggable quorum algorithm that can be passed into LighthouseServer to customize that as well.
Test plan: