Skip to content

Flatpak krokiet#1769

Merged
qarmin merged 27 commits intomasterfrom
flatpak_krokiet
Feb 5, 2026
Merged

Flatpak krokiet#1769
qarmin merged 27 commits intomasterfrom
flatpak_krokiet

Conversation

@qarmin
Copy link
Copy Markdown
Owner

@qarmin qarmin commented Feb 1, 2026

  • Adds removing files via portal, so files can be removed to trash
  • Update to slint 1.15

Fixes #1197
Fixes #811
Fixes #1545
Fixes #1720 - updating to slint 1.15, which fixes crash, that happened there

Screenshot From 2026-02-01 09-38-41 Screenshot From 2026-02-01 09-45-04

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Flatpak support to Krokiet by implementing XDG portal-based trash functionality, addressing file deletion issues in sandboxed environments (Flatpak). It also consolidates per-tool settings for hard links and cache management into global settings, updates Slint to version 1.14.1, migrates error messages to i18n, and improves the video optimizer's CLI interface by using strongly-typed codec enums.

Changes:

  • Implements XDG portal trash functionality for Linux Flatpak environments using ashpd and tokio
  • Consolidates hide_hard_links and delete_outdated_cache_entries settings from per-tool to global settings
  • Updates application metadata files (metainfo, desktop) with corrected IDs and license information
  • Migrates numerous error messages in core library to use fluent i18n translations
  • Changes video optimizer CLI to use strongly-typed VideoCodec enum instead of strings
  • Re-enables Android build checks in CI with blake_pure feature

Reviewed changes

Copilot reviewed 64 out of 65 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
czkawka_core/src/common/mod.rs Adds XDG portal trash implementation with tokio runtime management
czkawka_core/Cargo.toml Adds ashpd and tokio dependencies for XDG portal support
krokiet/src/settings/model.rs Consolidates hide_hard_links and delete_outdated_cache_entries to global settings
krokiet/ui/settings.slint Updates UI to reflect consolidated global settings
krokiet/ui/translations.slint Adds new translation strings for consolidated settings
krokiet/i18n/en/krokiet.ftl Adds English translations for new UI strings
czkawka_core/i18n/en/czkawka_core.ftl Adds extensive i18n strings for error messages
czkawka_cli/src/main.rs Updates CLI to use set_hide_hard_links() method
czkawka_cli/src/commands.rs Changes video codec parameters from String to VideoCodec enum
data/io.github.qarmin.krokiet.metainfo.xml New metainfo file with corrected app ID and license
data/io.github.qarmin.krokiet.desktop Updated desktop file comment (em dash to hyphen)
.github/workflows/linux.yml Re-enables Android build check with blake_pure feature
Cargo.lock Updates dependencies including slint 1.14.1, ashpd, tokio

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread czkawka_cli/src/main.rs Outdated
Comment thread czkawka_cli/src/main.rs Outdated
Comment thread czkawka_core/src/tools/video_optimizer/core.rs
Comment thread czkawka_core/src/common/mod.rs
Comment thread czkawka_core/src/common/mod.rs
Comment thread data/io.github.qarmin.krokiet.metainfo.xml
Comment thread data/io.github.qarmin.krokiet.metainfo.xml
Comment thread czkawka_cli/src/main.rs Outdated
@qarmin qarmin merged commit 76f4e03 into master Feb 5, 2026
27 of 28 checks passed
@qarmin qarmin deleted the flatpak_krokiet branch February 5, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants