Resolve relative UI theme paths against config folder#24658
Merged
glassez merged 1 commit intoJul 14, 2026
Conversation
thalieht
previously approved these changes
Jul 9, 2026
Member
|
Please note that there is no single profile directory in the "default profile mode". In this case, basePath points to the home directory. |
Chocobo1
reviewed
Jul 11, 2026
vrubleg
force-pushed
the
qbt-24489-relative-theme-path
branch
from
July 11, 2026 13:43
52efb3b to
7ba6a0b
Compare
vrubleg
force-pushed
the
qbt-24489-relative-theme-path
branch
from
July 11, 2026 13:45
7ba6a0b to
d6c5de2
Compare
glassez
changed the title
glassez
approved these changes
Jul 11, 2026
Member
|
@vrubleg |
Chocobo1
approved these changes
Jul 13, 2026
Member
|
@vrubleg |
glassez
pushed a commit
to glassez/qBittorrent
that referenced
this pull request
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #24514 fixed issue #24489 but added an inconsistency. qBittorrent does not store all its files in the
rootPath(profilein portable installation). It has one subdirectory with current internal profile name (that by default is just the name of the app):The real config directory is two levels deeper (
profile/qBittorrent/config), the ini-file that points to the theme file is also stored there. It would be logical to resolve theme path from the config directory. This PR should fix the inconsistency.