Skip to content

Add Feature: Retro Tapping Timeout #25138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

JohnRigoni
Copy link
Contributor

Description

Add a timeout to retro tapping.

With RETRO_TAPPING_TIMEOUT enabled, holding a dual function key for longer than the specified timeout duration will result in no keycode being sent when the key is released.

This setting can be enabled in your config.h and takes an integer that is the timeout duration in milliseconds.

Before RETRO_TAPPING_TIMEOUT

retro-timeout_before

After RETRO_TAPPING_TIMEOUT 😴

retro-timeout_after

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@JohnRigoni
Copy link
Contributor Author

This feature is following the retro tapping bug fix #23641. Hopefully these two changes revitalize the retro tapping workflow.

@drashna
Copy link
Member

drashna commented Apr 11, 2025

Would a per key option make sense here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants