Skip to content

chore: remove lock files #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 14, 2025
Merged

chore: remove lock files #2868

merged 7 commits into from
May 14, 2025

Conversation

AyushAgrawal-A2
Copy link
Collaborator

Description

removes lock files from repo (constantly causing merge conflicts)

Copy link

qa-wolf bot commented May 5, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label May 5, 2025
Copy link
Contributor

github-actions bot commented May 5, 2025

Preview - Build & Deploy Images

✅ Build images
✅ Deploy images

🕒 Last deployed: May 14, 2025 at 07:27 PM UTC

🔗 URL: https://ayush-lock-files.quadratic-preview.com

@github-actions github-actions bot temporarily deployed to preview-pr-2868 May 5, 2025 03:54 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2868 May 5, 2025 04:03 Destroyed
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (f6bfd08) to head (6cec966).

Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #2868   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files         410      410           
  Lines       93208    93208           
=======================================
  Hits        84416    84416           
  Misses       8792     8792           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot temporarily deployed to preview-pr-2868 May 5, 2025 08:47 Destroyed
@@ -45,7 +45,6 @@ jobs:
- uses: useblacksmith/setup-node@v5
with:
node-version: 23
cache: "npm"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning behind remove these?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs lock files for npm cache to work
all ci failed because of use of cache here and lock files not being available https://github.com/quadratichq/quadratic/actions/runs/14828701235

@ddimaria
Copy link
Collaborator

ddimaria commented May 5, 2025

I started in 🧵 in Slack to discuss this, but I think we should do this.

@github-actions github-actions bot temporarily deployed to preview-pr-2868 May 14, 2025 10:37 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2868 May 14, 2025 10:50 Destroyed
@AyushAgrawal-A2 AyushAgrawal-A2 merged commit 5f22e06 into qa May 14, 2025
23 checks passed
@AyushAgrawal-A2 AyushAgrawal-A2 deleted the ayush/lock_files branch May 14, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants