-
Notifications
You must be signed in to change notification settings - Fork 227
chore: remove lock files #2868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove lock files #2868
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Preview - Build & Deploy Images✅ Build images 🕒 Last deployed: May 14, 2025 at 07:27 PM UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## qa #2868 +/- ##
=======================================
Coverage 90.56% 90.56%
=======================================
Files 410 410
Lines 93208 93208
=======================================
Hits 84416 84416
Misses 8792 8792 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -45,7 +45,6 @@ jobs: | |||
- uses: useblacksmith/setup-node@v5 | |||
with: | |||
node-version: 23 | |||
cache: "npm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reasoning behind remove these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs lock files for npm cache to work
all ci failed because of use of cache here and lock files not being available https://github.com/quadratichq/quadratic/actions/runs/14828701235
I started in 🧵 in Slack to discuss this, but I think we should do this. |
Description
removes lock files from repo (constantly causing merge conflicts)