Skip to content

chore: remove lock files #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 14, 2025
Merged

chore: remove lock files #2868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
17be40a
chore: remove lock files
AyushAgrawal-A2 May 5, 2025
96af087
update dockerfiles
AyushAgrawal-A2 May 5, 2025
4d37106
npm ci cache
AyushAgrawal-A2 May 5, 2025
fc38bdc
fix js
AyushAgrawal-A2 May 5, 2025
8f95610
Merge branch 'qa' of github.com:quadratichq/quadratic into ayush/lock…
AyushAgrawal-A2 May 14, 2025
bba3498
fix api build
AyushAgrawal-A2 May 14, 2025
6cec966
Merge branch 'qa' into ayush/lock_files
AyushAgrawal-A2 May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ jobs:
- uses: useblacksmith/setup-node@v5
with:
node-version: 23
cache: "npm"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning behind remove these?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs lock files for npm cache to work
all ci failed because of use of cache here and lock files not being available https://github.com/quadratichq/quadratic/actions/runs/14828701235


- name: Set up Rust
uses: actions-rs/toolchain@v1
Expand Down Expand Up @@ -127,7 +126,6 @@ jobs:
- uses: useblacksmith/setup-node@v5
with:
node-version: 23
cache: "npm"

- uses: useblacksmith/setup-python@v6
with:
Expand Down Expand Up @@ -172,7 +170,6 @@ jobs:
- uses: useblacksmith/setup-node@v5
with:
node-version: 23
cache: "npm"

- uses: useblacksmith/setup-python@v6
with:
Expand All @@ -194,7 +191,6 @@ jobs:
- uses: useblacksmith/setup-node@v5
with:
node-version: 23
cache: "npm"

- name: Run npm test:ci in quadratic-api
run: |
Expand Down Expand Up @@ -238,7 +234,6 @@ jobs:
- uses: useblacksmith/setup-node@v5
with:
node-version: 23
cache: "npm"

- name: Set up Rust
uses: actions-rs/toolchain@v1
Expand Down
5 changes: 5 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,15 @@
# dependencies
node_modules
**/node_modules
package-lock.json
**/package-lock.json
/.pnp
.pnp.js
.cache
/.cargo
Cargo.lock
**/Cargo.lock

# testing
/coverage

Expand Down
1 change: 1 addition & 0 deletions infra/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
/bin/
/node_modules/
package-lock.json
Loading
Loading