feat(kernel-configs): enable kernel support for iwd#267
feat(kernel-configs): enable kernel support for iwd#267koenkooi wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
When trying to use `iwd` as backend for NetworkManager it fails with: ``` Feb 26 09:26:40 rb4 systemd[1]: Failed to start iwd.service - Wireless service. Feb 26 09:26:40 rb4 systemd[1]: iwd.service: Scheduled restart job, restart counter is at 1. Feb 26 09:26:40 rb4 systemd[1]: Starting iwd.service - Wireless service... Feb 26 09:26:40 rb4 iwd[736]: No HMAC(SHA1) support found Feb 26 09:26:40 rb4 iwd[736]: No HMAC(MD5) support found Feb 26 09:26:40 rb4 iwd[736]: No CMAC(AES) support found Feb 26 09:26:40 rb4 iwd[736]: No HMAC(SHA256) support not found Feb 26 09:26:40 rb4 iwd[736]: No HMAC(SHA512) support found, certain TLS connections might fail Feb 26 09:26:40 rb4 iwd[736]: DES support not found Feb 26 09:26:40 rb4 iwd[736]: AES support not found Feb 26 09:26:40 rb4 iwd[736]: No CBC(DES3_EDE) support found, certain TLS connections might fail Feb 26 09:26:40 rb4 iwd[736]: No CBC(AES) support found, WPS will not be available Feb 26 09:26:40 rb4 iwd[736]: No Diffie-Hellman support found, WPS will not be available Feb 26 09:26:40 rb4 iwd[736]: The following options are missing in the kernel: Feb 26 09:26:40 rb4 iwd[736]: CONFIG_CRYPTO_USER_API_HASH Feb 26 09:26:40 rb4 iwd[736]: CONFIG_CRYPTO_USER_API_SKCIPHER Feb 26 09:26:40 rb4 iwd[736]: CONFIG_KEY_DH_OPERATIONS Feb 26 09:26:40 rb4 iwd[736]: CONFIG_CRYPTO_ECB Feb 26 09:26:40 rb4 iwd[736]: CONFIG_CRYPTO_MD5 Feb 26 09:26:40 rb4 iwd[736]: CONFIG_CRYPTO_CBC Feb 26 09:26:40 rb4 iwd[736]: CONFIG_CRYPTO_SHA256 Feb 26 09:26:40 rb4 iwd[736]: CONFIG_CRYPTO_AES Feb 26 09:26:40 rb4 iwd[736]: CONFIG_CRYPTO_DES Feb 26 09:26:40 rb4 iwd[736]: CONFIG_CRYPTO_CMAC Feb 26 09:26:40 rb4 iwd[736]: CONFIG_CRYPTO_HMAC Feb 26 09:26:40 rb4 iwd[736]: CONFIG_CRYPTO_SHA512 Feb 26 09:26:40 rb4 iwd[736]: CONFIG_CRYPTO_SHA1 ``` Enable those options as well as all accelerated crypto drivers to make this work. Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
Test jobs for commit cdc66b9 |
lool
left a comment
lool
left a comment
There was a problem hiding this comment.
Thanks! Could you make the use case a bit more specific (what we get) and convey how you crafted it (how we maintain it)?
Not sure that the second crypto group brings, I'm sure it can be made useful, but perhaps it belongs in its own config fragment for $something.
| CONFIG_CRYPTO_RSA=y | ||
| CONFIG_CRYPTO_SHA1=m | ||
| CONFIG_CRYPTO_SHA256=m | ||
| CONFIG_CRYPTO_SHA512=y |
There was a problem hiding this comment.
This and probably others are tristate; any rationale for making them =y? I'd prefer keeping everything we can as module by default.
| @@ -0,0 +1,52 @@ | |||
| # Wifi | |||
There was a problem hiding this comment.
This and the name of the file ("wireless") might be a bit too generic; WiFi works for me with defconfig and the default Network Manager backend. Should this be iwd.config?
Could you start with a couple of lines describing the use case / userspace being enabled? In your case I believe it's (Debian's) IWD and (Debian's) Network Manager's IWD backend
Could you also write some notes on how you crafted the config in the header itself? I am worried we won't know how to update these config files in a few months.
| CONFIG_PKCS7_MESSAGE_PARSER=y | ||
| CONFIG_X509_CERTIFICATE_PARSER=y | ||
|
|
||
| # Accelerated crypto drivers for Arm |
There was a problem hiding this comment.
I'm not sure I see the difference between the crypto configs in this group vs the above ones; is this a broad set of crypto modules that might or might not be used in wireless? It seems the top set is about wireless already?
There was a problem hiding this comment.
I did a similar change in meta-qcom and the request was to enable all the Arm crypto drivers and not just the handful iwd likes. I have no strong opinion on keeping them.
There was a problem hiding this comment.
I want to remain grounded on real use cases; this set of configs is essentially went to be a small superset on top of defconfig to support developer needs, but I don't think we'd want to turn on every config under the sun like you'd see in a distro kernel.
For me the use case is Koen, other Qualcomm engineers and opensource developers want to run iwd. Could you make an educated guess of the configs that make sense? It's ok to include a bit more with the idea "Wireless protocols might use this alg in the short/mid-term".
Alternatively, if you know of interesting use cases that would require the crypto subsystem, say dm-crypt or ICE, we could take this opportunity to create a separate and richer crypto.config or dm-crypt.config.
|
BTW I am also curious as to why you're reaching out to the alternate iwd backend! |
Because it's much, much easier to configure and debug than wpa-supplicant! |
2 participants
When trying to use
iwdas backend for NetworkManager it fails with:Enable those options as well as all accelerated crypto drivers to make this work.