feat(kernel-configs): enable kernel support for iwd #267
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| # Wifi | ||
| CONFIG_ASYMMETRIC_KEY_TYPE=y | ||
| CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE=y | ||
| CONFIG_CFG80211_CRDA_SUPPORT=y | ||
| CONFIG_CRYPTO_AES=y | ||
| CONFIG_CRYPTO_ARC4=m | ||
| CONFIG_CRYPTO_CBC=m | ||
| CONFIG_CRYPTO_CMAC=m | ||
| CONFIG_CRYPTO_DES=m | ||
| CONFIG_CRYPTO_ECB=y | ||
| CONFIG_CRYPTO_HMAC=y | ||
| CONFIG_CRYPTO_MD4=m | ||
| CONFIG_CRYPTO_MD5=m | ||
| CONFIG_CRYPTO_RSA=y | ||
| CONFIG_CRYPTO_SHA1=m | ||
| CONFIG_CRYPTO_SHA256=m | ||
| CONFIG_CRYPTO_SHA512=y | ||
|
Contributor
There was a problem hiding this comment. This and probably others are tristate; any rationale for making them =y? I'd prefer keeping everything we can as module by default. |
||
| CONFIG_CRYPTO_USER_API_AEAD=m | ||
| CONFIG_CRYPTO_USER_API_HASH=m | ||
| CONFIG_CRYPTO_USER_API_SKCIPHER=m | ||
| CONFIG_KEY_DH_OPERATIONS=y | ||
| CONFIG_PKCS7_MESSAGE_PARSER=y | ||
| CONFIG_X509_CERTIFICATE_PARSER=y | ||
|
|
||
| # Accelerated crypto drivers for Arm | ||
|
Contributor
There was a problem hiding this comment. I'm not sure I see the difference between the crypto configs in this group vs the above ones; is this a broad set of crypto modules that might or might not be used in wireless? It seems the top set is about wireless already?
Contributor
Author
There was a problem hiding this comment. I did a similar change in meta-qcom and the request was to enable all the Arm crypto drivers and not just the handful iwd likes. I have no strong opinion on keeping them.
Contributor
There was a problem hiding this comment. I want to remain grounded on real use cases; this set of configs is essentially went to be a small superset on top of defconfig to support developer needs, but I don't think we'd want to turn on every config under the sun like you'd see in a distro kernel. For me the use case is Koen, other Qualcomm engineers and opensource developers want to run iwd. Could you make an educated guess of the configs that make sense? It's ok to include a bit more with the idea "Wireless protocols might use this alg in the short/mid-term". Alternatively, if you know of interesting use cases that would require the crypto subsystem, say dm-crypt or ICE, we could take this opportunity to create a separate and richer crypto.config or dm-crypt.config. |
||
| CONFIG_CRYPTO_AES_ARM64_BS=m | ||
| CONFIG_CRYPTO_AES_ARM64_CE_BLK=m | ||
| CONFIG_CRYPTO_AES_ARM64_CE_CCM=m | ||
| CONFIG_CRYPTO_AES_ARM64_CE=m | ||
| CONFIG_CRYPTO_AES_ARM64=m | ||
| CONFIG_CRYPTO_AES_ARM64_NEON_BLK=m | ||
| CONFIG_CRYPTO_AES_ARM_BS=m | ||
| CONFIG_CRYPTO_AES_ARM_CE=m | ||
| CONFIG_CRYPTO_AES_ARM=m | ||
| CONFIG_CRYPTO_BLAKE2B_NEON=m | ||
| CONFIG_CRYPTO_BLAKE2S_ARM=m | ||
| CONFIG_CRYPTO_CHACHA20_NEON=m | ||
| CONFIG_CRYPTO_CURVE25519_NEON=m | ||
| CONFIG_CRYPTO_GHASH_ARM64_CE=m | ||
| CONFIG_CRYPTO_GHASH_ARM_CE=m | ||
| CONFIG_CRYPTO_NHPOLY1305_NEON=m | ||
| CONFIG_CRYPTO_POLY1305_ARM=m | ||
| CONFIG_CRYPTO_POLY1305_NEON=m | ||
| CONFIG_CRYPTO_POLYVAL_ARM64_CE=m | ||
| CONFIG_CRYPTO_SHA3_ARM64=m | ||
| CONFIG_CRYPTO_SM3_ARM64_CE=m | ||
| CONFIG_CRYPTO_SM3_NEON=m | ||
| CONFIG_CRYPTO_SM4_ARM64_CE_BLK=m | ||
| CONFIG_CRYPTO_SM4_ARM64_CE_CCM=m | ||
| CONFIG_CRYPTO_SM4_ARM64_CE_GCM=m | ||
| CONFIG_CRYPTO_SM4_ARM64_CE=m | ||
| CONFIG_CRYPTO_SM4_ARM64_NEON_BLK=m | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the name of the file ("wireless") might be a bit too generic; WiFi works for me with defconfig and the default Network Manager backend. Should this be iwd.config?
Could you start with a couple of lines describing the use case / userspace being enabled? In your case I believe it's (Debian's) IWD and (Debian's) Network Manager's IWD backend
Could you also write some notes on how you crafted the config in the header itself? I am worried we won't know how to update these config files in a few months.