-
Notifications
You must be signed in to change notification settings - Fork 1.1k
CI - skip sorting of imports with isort #7190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The `check/format-incremental` needs more work. isort invocation should skip `__init__.py` files, but it does not. Related to quantumlib#7181
check/format-incremental
Outdated
isort "${args[@]}" "${format_files[@]}" | ||
ISORTSTATUS=$? | ||
echo "skipped"; ISORTSTATUS=0 | ||
# isort "${args[@]}" "${format_files[@]}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer not having commented code in script files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in ac22abb
NB: this is a quick fix to prevent isort misbehaving in CI checks. To be reverted after fixups in |
What happened? It worked for me when I added the skip directive to the config. |
The The |
Oh I see. The skip directive only works when calling |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7190 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 1100 1100
Lines 96191 96191
=======================================
Hits 94409 94409
Misses 1782 1782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* CI - skip sorting of imports with isort The `check/format-incremental` needs more work. isort invocation should skip `__init__.py` files, but it does not. Related to quantumlib#7181 * Add TODO note for re-enabling isort
The
check/format-incremental
needs more work.isort invocation should skip
__init__.py
files, but it does not.Related to #7181