Skip to content

[3.33] Quarkus REST: fix @Context injection for records #53502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FroMage wants to merge 2 commits into
base: 3.33
Choose a base branch
from
+8 −4
Open

[3.33] Quarkus REST: fix @Context injection for records #53502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71bec7d
Quarkus REST: fix `@Context` injection for records
FroMage Apr 8, 2026
31a8b5e
Quarkus REST: test that context params are injected in records
FroMage Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...src/test/java/io/quarkus/resteasy/reactive/server/test/beanparam/BeanParamRecordTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ void shouldWork() {
.get("/record")
.then()
.statusCode(200)
.body(equalTo("got it/2/3/4/5/6.0/7.0/true/a/query/query/query/query"));
.body(equalTo("got it/2/3/4/5/6.0/7.0/true/a/query/query/query/query//record"));

}

Expand Down Expand Up @@ -102,7 +102,8 @@ public String beanParamRecord(BeanParamRecord p, @RestHeader String headerParam)
+ p.obp().q + "/"
+ p.obp().obpr.q() + "/"
+ p.obp().obpc.q + "/"
+ p.obpr().q;
+ p.obpr().q + "/"
+ p.uriInfo().getPath();
}
}
}
7 changes: 5 additions & 2 deletions .../java/org/jboss/resteasy/reactive/server/processor/scanning/ClassInjectorTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ public void visitEnd() {
case CONTEXT:
// already set by CDI for non-records
if (isRecord) {
injectContextParameter(injectMethod, fieldInfo, ctxParamIndex);
injectContextParameterForRecord(injectMethod, fieldInfo, fieldIndex, ctxParamIndex);
}
break;
case FORM:
Expand Down Expand Up @@ -489,7 +489,8 @@ private void injectBeanParameter(MethodVisitor injectMethod, FieldInfo fieldInfo
}
}

private void injectContextParameter(MethodVisitor injectMethod, FieldInfo fieldInfo, int ctxParamIndex) {
private void injectContextParameterForRecord(MethodVisitor injectMethod, FieldInfo fieldInfo, int fieldIndex,
int ctxParamIndex) {
// ctx param
injectMethod.visitVarInsn(Opcodes.ALOAD, ctxParamIndex);
// type
Expand All @@ -498,6 +499,8 @@ private void injectContextParameter(MethodVisitor injectMethod, FieldInfo fieldI
injectMethod.visitMethodInsn(Opcodes.INVOKEINTERFACE, QUARKUS_REST_INJECTION_CONTEXT_BINARY_NAME,
"getContextParameter",
"(Ljava/lang/Class;)Ljava/lang/Object;", true);
// store our param field
injectMethod.visitVarInsn(AsmUtil.getStoreOpcode(fieldInfo.type()), fieldIndex);
}

private void generateMultipartFormFields(FieldInfo fieldInfo, ServerIndexedParameter extractor) {
Expand Down
Loading