Merged
Conversation
crekhari
force-pushed
the
user-identifier-resource-attr
branch
from
62d59f6 to
5dcf3d5
Compare
freddiev4
reviewed
Jul 16, 2025
quotientai/client.py
Outdated
| self.token = None | ||
| self.token_expiry = 0 | ||
| self.token_api_key = None | ||
| self.user_id = None |
Member
There was a problem hiding this comment.
I suggest calling this self.__user
quotientai/tracing/core.py
Outdated
| resource_attributes = { | ||
| QuotientAttributes.app_name: app_name, | ||
| QuotientAttributes.environment: environment, | ||
| "quotient.user_id": self._get_user_id(), |
Member
There was a problem hiding this comment.
Let's add this to QuotientAttributes as quotient.user
quotientai/_constants.py
Outdated
| @@ -1,3 +1,5 @@ | |||
| TRACER_NAME = "quotient.sdk.python" | |||
| DEFAULT_TRACING_ENDPOINT = "https://otel.quotientai.co/v1/traces" | |||
| # DEFAULT_TRACING_ENDPOINT = "http://localhost:4318/v1/traces" | |||
Contributor
Author
There was a problem hiding this comment.
I lowkey wanted to keep it in here just for dev purposes. Ill remove it along w/ the other fixes
Member
There was a problem hiding this comment.
If you want to do that you could make this an env var.
Suggested change
| # DEFAULT_TRACING_ENDPOINT = "http://localhost:4318/v1/traces" | |
| OTLP_TRACING_ENDPOINT = os.environ.get(“OTLP_TRACING_ENDPOINT”, “https://otel.quotientai.co/v1/traces”) |
Co-authored-by: Freddie Vargus <freddie@quotientai.co>
freddiev4
reviewed
Jul 16, 2025
quotientai/tracing/core.py
Outdated
| resource_attributes = { | ||
| QuotientAttributes.app_name: app_name, | ||
| QuotientAttributes.environment: environment, | ||
| "quotient.user": self._get_user(), |
Member
There was a problem hiding this comment.
Can we make this QuotientAttributes.user?
Otherwise LGTM
freddiev4
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds jwt as a resource attr for the quollector to authenticate.