-
Notifications
You must be signed in to change notification settings - Fork 2
User identifier resource attr #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a6af40a
Add api key as resource attribute
crekhari 749803f
jwt auth
crekhari 5dcf3d5
api key
crekhari 557e8e0
user_id instead of jwt
crekhari c8f4331
clean
crekhari 027f7c9
Update quotientai/tracing/core.py
crekhari a0f21f3
fixes from review
crekhari 659ec96
newline
crekhari ebc475d
quotientattr
crekhari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| TRACER_NAME = "quotient.sdk.python" | ||
| DEFAULT_TRACING_ENDPOINT = "https://otel.quotientai.co/v1/traces" | ||
| # DEFAULT_TRACING_ENDPOINT = "http://localhost:4318/v1/traces" | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,6 +32,7 @@ def __init__(self, api_key: str): | |
| self.token = None | ||
| self.token_expiry = 0 | ||
| self.token_api_key = None | ||
| self.user_id = None | ||
|
||
| self._token_path = ( | ||
| token_dir | ||
| / ".quotient" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -123,6 +123,17 @@ def _create_otlp_exporter(self, endpoint: str, headers: dict): | |
| """ | ||
| return OTLPSpanExporter(endpoint=endpoint, headers=headers) | ||
|
|
||
|
|
||
| def _get_user_id(self): | ||
| """ | ||
| Get user_id from client. | ||
| Returns the user_id or None if not found. | ||
| """ | ||
| if hasattr(self._client, 'user_id'): | ||
| return self._client.user_id | ||
| return None | ||
crekhari marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
|
|
||
| @functools.lru_cache() | ||
| def _setup_auto_collector(self, app_name: str, environment: str, instruments: Optional[tuple] = None, detections: Optional[str] = None): | ||
| """ | ||
|
|
@@ -139,6 +150,7 @@ def _setup_auto_collector(self, app_name: str, environment: str, instruments: Op | |
| resource_attributes = { | ||
| QuotientAttributes.app_name: app_name, | ||
| QuotientAttributes.environment: environment, | ||
| "quotient.user_id": self._get_user_id(), | ||
|
||
| } | ||
|
|
||
| if detections is not None: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cruft?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I lowkey wanted to keep it in here just for dev purposes. Ill remove it along w/ the other fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to do that you could make this an env var.