Fix xref cleanup ordering and purge - #26473
Merged
trufae merged 1 commit intoAug 15, 2026
Merged
Conversation
Free the xref manager before destroying the analysis lock to avoid using a destroyed mutex during teardown. Reinitialize the manager during purge so references from the previous analysis cannot survive into the next one.
0verflowme
marked this pull request as ready for review
August 15, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
r_anal_free()destroyedanal->lockbefore callingr_anal_xrefs_free(), even though xref cleanup acquires that lock. This could access a destroyed mutex during teardown.r_anal_purge()reset functions, metadata, types, and imports but retained the old xref manager, allowing references from the previous analysis to survive into the next one.Validation
mastertest_anal_xrefs: 2/2 passinggit diff --check