Skip to content

Fix xref cleanup ordering and purge #26473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trufae merged 1 commit into from
Aug 15, 2026
+20 −1
Merged

Fix xref cleanup ordering and purge #26473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libr/anal/anal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@ R_API void r_anal_free(RAnal *a) {
r_bitset_free (a->visited);
}
r_anal_hint_storage_fini (a);
r_anal_xrefs_free (a);
r_th_lock_free (a->lock);
r_interval_tree_fini (&a->meta);
r_unref (a->config);
Expand All @@ -315,7 +316,6 @@ R_API void r_anal_free(RAnal *a) {
r_anal_pin_fini (a);
r_syscall_free (a->syscall);
r_unref (a->reg);
r_anal_xrefs_free (a);
r_list_free (a->threads);
r_list_free (a->leaddrs);
sdb_free (a->sdb);
Expand Down Expand Up @@ -534,6 +534,7 @@ R_API void r_anal_purge(RAnal *anal) {
sdb_reset (anal->sdb_cc);
r_list_free (anal->fcns);
anal->fcns = r_list_newf ((RListFree)r_anal_function_free);
(void)r_anal_xrefs_init (anal);
r_anal_purge_imports (anal);
}

Expand Down
18 changes: 18 additions & 0 deletions test/unit/test_anal_xrefs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,26 @@ bool test_r_anal_xrefs_count(void) {
mu_end;
}

bool test_r_anal_purge_clears_xrefs(void) {
RAnal *anal = r_anal_new ();

mu_assert_true (r_anal_xrefs_set (anal, 0x1000, 0x2000, R_ANAL_REF_TYPE_CODE),
"add xref before purge");
mu_assert_eq (r_anal_xrefs_count (anal), 1, "xref exists before purge");

r_anal_purge (anal);
mu_assert_eq (r_anal_xrefs_count (anal), 0, "purge clears xrefs");
mu_assert_true (r_anal_xrefs_set (anal, 0x3000, 0x4000, R_ANAL_REF_TYPE_CALL),
"xref manager remains usable after purge");
mu_assert_eq (r_anal_xrefs_count (anal), 1, "xref added after purge");

r_anal_free (anal);
mu_end;
}

int all_tests(void) {
mu_run_test (test_r_anal_xrefs_count);
mu_run_test (test_r_anal_purge_clears_xrefs);
return tests_passed != tests_run;
}

Expand Down
Loading