Skip to content

Show VMware pool location#17774

Open
davidhrbac wants to merge 1 commit into
rancher:masterfrom
davidhrbac:vmware-provider-location
Open

Show VMware pool location#17774
davidhrbac wants to merge 1 commit into
rancher:masterfrom
davidhrbac:vmware-provider-location

Conversation

@davidhrbac
Copy link
Copy Markdown

@davidhrbac davidhrbac commented May 21, 2026

Summary

Fixes #17776

Occurred changes and/or fixed issues

  • derive the VMware provider location from the resource pool path when it follows the /host/<location>/Resources/... shape
  • keep the existing No Location fallback when the path does not match that shape
  • add a focused unit test covering VMware machine template provider location parsing

Technical notes summary

  • the displayed location is parsed from the path segment between /host/ and /Resources
  • paths that do not match the expected vSphere shape still use the existing fallback

Areas or cases that should be tested

  • a VMware machine pool whose resource pool path includes /host/<location>/Resources/... should show <location> instead of No Location
  • a VMware machine pool whose path does not match that shape should still show No Location
  • browser used for local testing: not run in this environment

Areas which could experience regressions

  • VMware machine pool/provider location rendering
  • any UI code that depends on the parsed provider location string for VMware machine templates

Screenshot/Video

  • not included

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes
  • The PR has been reviewed in terms of Accessibility
  • The PR has considered, and if applicable tested with, the three Global Roles Admin, Standard User and User Base

Copy link
Copy Markdown
Member

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create an accompanying gh issue, and also fill in the gh pr template?

@davidhrbac
Copy link
Copy Markdown
Author

Created companion issue #17776 and updated the PR body to the repository template. The milestone-related checklist items are still unchecked because I cannot assign milestones from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show VMware pool location in cluster provisioning

2 participants