Skip to content

Show VMware pool location #17774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidhrbac wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −0
Open

Show VMware pool location #17774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions shell/models/__tests__/rke-machine.cattle.io.vmwarevspheremachinetemplate.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import VmwarevsphereMachineTemplate from '@shell/models/rke-machine.cattle.io.vmwarevspheremachinetemplate';

describe('class VmwarevsphereMachineTemplate', () => {
describe('providerLocation', () => {
it.each([
['/DC1/host/ClusterA/Resources', 'ClusterA'],
['/DC1/host/ClusterA/Resources/PoolX', 'ClusterA'],
['/DC1/host/esxi01/Resources', 'esxi01'],
['/DC1/vm/FolderA', null],
[undefined, null],
])('should derive provider location from pool path %p', (pool: string | undefined, expected: string | null) => {
const machineTemplate = new VmwarevsphereMachineTemplate({
spec: {
template: {
spec: { pool }
}
}
});

expect(machineTemplate.providerLocation).toStrictEqual(expected);
});
});
});
9 changes: 9 additions & 0 deletions shell/models/rke-machine.cattle.io.vmwarevspheremachinetemplate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,20 @@
import { formatSi } from '@shell/utils/units';
import MachineTemplate from './rke-machine.cattle.io.machinetemplate';

const POOL_LOCATION_MATCHER = /\/host\/([^/]+)\/Resources(?:\/|$)/;

export default class VmwarevsphereMachineTemplate extends MachineTemplate {
get provider() {
return 'vmwarevsphere';
}

get providerLocation() {
const pool = this.spec?.template?.spec?.pool;
const match = pool?.match(POOL_LOCATION_MATCHER);

return match?.[1] || null;
}

get providerSize() {
const size = formatSi(this.spec.template.spec.memorySize * 1048576, 1024, 'iB');

Expand Down