-
Notifications
You must be signed in to change notification settings - Fork 128
Update release documentation with additional steps #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HarrisonWAffel
wants to merge
1
commit into
rancher:dev-v2.12
Choose a base branch
from
HarrisonWAffel:update-docs
base: dev-v2.12
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the checklist! 🎉
appDefaultsandmin/maxChannelServerVersionhave different purposes:appDefaultsis only there to indicate the default k8s version for rancher server version. Rancher server version range is set byappVersionand the intended default k8s version is set bydefaultVersion. For example, if a new release of Rancher v2.12.0 is being released, we need to have the upper bound of theappVersionto at least< v2.12.100-0for the intended default k8s version (defaultVersion: v1.33.x). Updating other k8s versions isn't required.The actual decision of whether the k8s version will be available for a particular rancher server is decided by
releasessection which hasmin/maxChannelServerVersionand must be updated for all supported k8s versions.