updatecli: Prevent gh/XDG state files from polluting autocreated PRs#10548
Open
mgfritch wants to merge 1 commit into
Open
updatecli: Prevent gh/XDG state files from polluting autocreated PRs#10548mgfritch wants to merge 1 commit into
mgfritch wants to merge 1 commit into
Conversation
Prevent XDG state/config/data/cache dirs that tools like `gh` may write into the worktree Signed-off-by: Michael Fritch <mfritch@suse.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10548 +/- ##
=======================================
Coverage 19.82% 19.82%
=======================================
Files 50 50
Lines 4136 4136
=======================================
Hits 820 820
Misses 3265 3265
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rbrtbnfgl
approved these changes
Jun 5, 2026
rbrtbnfgl
reviewed
Jun 5, 2026
|
|
||
| update_chart_images_windows() { | ||
| app_version="${2%??}" | ||
| tempdir=$(mktemp -d) |
Contributor
There was a problem hiding this comment.
I think we don't need the tempdir anymore
Contributor
Author
There was a problem hiding this comment.
yup! it's been removed
rbrtbnfgl
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent XDG state/config/data/cache dirs that tools like
ghmay write into the worktreeFixes: #10529 (comment)
DISCLAIMER: No AI was harmed in the creation of this PR (thanks co-pilot)!