Skip to content

updatecli: Prevent gh/XDG state files from polluting autocreated PRs #10548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgfritch wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −2
Open

updatecli: Prevent gh/XDG state files from polluting autocreated PRs #10548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
/.dapper
/.cache
/.local/
/.config/
/bin
/dist
*.swp
Expand Down
9 changes: 7 additions & 2 deletions updatecli/scripts/update_chart_and_images_cni.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,12 @@ $0 ~ pattern {

update_chart_images_windows() {
app_version="${2%??}"
tempdir=$(mktemp -d)

@rbrtbnfgl rbrtbnfgl Jun 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need the tempdir anymore

@mgfritch mgfritch Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup! it's been removed

gh_state_dir=$(mktemp -d -t gh_state_dir.XXXXXX)
export GH_CONFIG_DIR="${gh_state_dir}/gh-config"
export XDG_CONFIG_HOME="${gh_state_dir}/xdg-config"
export XDG_STATE_HOME="${gh_state_dir}/xdg-state"
export XDG_DATA_HOME="${gh_state_dir}/xdg-data"
export XDG_CACHE_HOME="${gh_state_dir}/xdg-cache"
case "${1}" in
"rke2-flannel")
flanneld_sha256=$(gh api repos/flannel-io/flannel/releases/tags/${app_version} --jq '.assets[] | select(.name == "flanneld.exe") | .digest' | cut -d':' -f2)
Expand Down Expand Up @@ -132,7 +137,7 @@ update_chart_images_windows() {
sed -i "s/ENV CALICO_VERSION=.*/ENV CALICO_VERSION=\"$app_version\"/g" Dockerfile.windows
;;
esac
rm -rf $tempdir/
rm -rf "$gh_state_dir"
}

CHART_VERSIONS_FILE="charts/chart_versions.yaml"
Expand Down
Loading