fix: resolve variable problems in nix shell#141
Merged
Conversation
Signed-off-by: matttrach <matt.trachier@suse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem with nix shell environments that I overlooks previously. Since the nix shell ignores environment variables that aren't standard/ specified I need to export any extra environment variables in the run command.
This was manifesting in a missing acme server url in the environment.
I also added a missing line to set the acme server url in the test if it isn't in the environment.
And I removed default values from the variables in the example so that we fail earlier in the process if this happens again.