Skip to content

fix: resolve variable problems in nix shell #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matttrach merged 1 commit into from
Dec 2, 2025
+9 −10
Merged

fix: resolve variable problems in nix shell #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,15 +104,16 @@ jobs:
AWS_ACCESS_KEY_ID: ${{ steps.aws-creds.outputs.aws-access-key-id }}
AWS_SECRET_ACCESS_KEY: ${{ steps.aws-creds.outputs.aws-secret-access-key }}
AWS_SESSION_TOKEN: ${{ steps.aws-creds.outputs.aws-session-token }}
AWS_MAX_ATTEMPTS: 100
AWS_RETRY_MODE: adaptive
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
GITHUB_OWNER: rancher
IDENTIFIER: ${{github.run_id}}
ZONE: ${{secrets.ZONE}}
ACME_SERVER_URL: https://acme-v02.api.letsencrypt.org/directory
RANCHER_INSECURE: false
IDENTIFIER: ${{github.run_id}}
run: |
# nix ignores environment variables that are not specifically kept
export AWS_MAX_ATTEMPTS="100"
export AWS_RETRY_MODE="adaptive"
export GITHUB_OWNER="rancher"
export ACME_SERVER_URL="https://acme-v02.api.letsencrypt.org/directory"
export RANCHER_INSECURE="false"
./run_tests.sh -s

cleanup:
Expand Down Expand Up @@ -146,9 +147,9 @@ jobs:
AWS_ACCESS_KEY_ID: ${{ steps.aws-creds.outputs.aws-access-key-id }}
AWS_SECRET_ACCESS_KEY: ${{ steps.aws-creds.outputs.aws-secret-access-key }}
AWS_SESSION_TOKEN: ${{ steps.aws-creds.outputs.aws-session-token }}
AWS_MAX_ATTEMPTS: 100
IDENTIFIER: ${{github.run_id}}
run: |
export AWS_MAX_ATTEMPTS="100"
./run_tests.sh -c $IDENTIFIER

report:
Expand Down
3 changes: 0 additions & 3 deletions examples/downstream/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ variable "rancher_version" {
description = <<-EOT
The version of rancher to install on the rke2 cluster.
EOT
default = "2.9.1"
}
variable "file_path" {
type = string
Expand All @@ -58,15 +57,13 @@ variable "acme_server_url" {
The ACME server URL to use for cert-manager.
This is useful for using the Let's Encrypt staging server for testing.
EOT
default = "https://acme-staging-v02.api.letsencrypt.org/directory"
}
variable "runner_ip" {
type = string
description = <<-EOT
The IP of the sever running Terraform.
Only this IP will have access to the cluster.
EOT
default = ""
}
variable "aws_access_key_id" {
type = string
Expand Down
1 change: 1 addition & 0 deletions test/tests/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@ func SetAcmeServer(t *testing.T) string {
acmeserver := os.Getenv("ACME_SERVER_URL")
if acmeserver == "" {
os.Setenv("ACME_SERVER_URL", "https://acme-staging-v02.api.letsencrypt.org/directory") //nolint usetesting
acmeserver = "https://acme-staging-v02.api.letsencrypt.org/directory"
}
return acmeserver
}
Expand Down