-
Notifications
You must be signed in to change notification settings - Fork 26
🌱 Use fleet to deploy CNI across all providers #1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmazzotti
reviewed
Apr 9, 2025
test/e2e/suites/etcd-snapshot-restore/etcd_snapshot_restore_test.go
Outdated
Show resolved
Hide resolved
c4e6f5e
to
4969592
Compare
alexander-demicev
previously approved these changes
Apr 14, 2025
anmazzotti
previously approved these changes
Apr 14, 2025
9e92abd
9e92abd
to
2292260
Compare
anmazzotti
previously approved these changes
Apr 14, 2025
ae4993d
to
6b2af14
Compare
mjura
reviewed
Apr 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks that CI is failing:
Unexpected error:
<template.ExecError>:
template: fleet-repo-template:12:9: executing "fleet-repo-template" at <.Revision>: can't evaluate field Revision in type framework.FleetCreateGitRepoInput
{
Name: "fleet-repo-template",
Err: <*errors.errorString | 0xc000494ef0>{
s: "template: fleet-repo-template:12:9: executing \"fleet-repo-template\" at <.Revision>: can't evaluate field Revision in type framework.FleetCreateGitRepoInput",
},
}
345a632
to
d90cb8e
Compare
d90cb8e
to
5f0b223
Compare
mjura
approved these changes
Apr 16, 2025
This was referenced Apr 17, 2025
I still think this may break nightly E2E tests. We should validate the workflow on this version, perhaps creating a new branch and running it from there. |
5f0b223
to
e72f508
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changing how overall CNI is deployed across providers. Additionally moving
kindnet.yaml
into examples and removing oldcalico.yaml
as well as places where it was redundantly used.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1256
Special notes for your reviewer:
Checklist: