Skip to content

🌱 Use fleet to deploy CNI across all providers #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Apr 9, 2025

What this PR does / why we need it:

Changing how overall CNI is deployed across providers. Additionally moving kindnet.yaml into examples and removing old calico.yaml as well as places where it was redundantly used.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1256

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner April 9, 2025 16:02
@Danil-Grigorev Danil-Grigorev added area/testing Indicates an issue related to test kind/ci Issues or PRs related to CI workflows labels Apr 9, 2025
@Danil-Grigorev Danil-Grigorev changed the title Use fleet to deploy CNI across all providers 🌱 Use fleet to deploy CNI across all providers Apr 9, 2025
@Danil-Grigorev Danil-Grigorev force-pushed the use-fleet-for-cni branch 3 times, most recently from c4e6f5e to 4969592 Compare April 14, 2025 11:39
anmazzotti
anmazzotti previously approved these changes Apr 14, 2025
@Danil-Grigorev Danil-Grigorev force-pushed the use-fleet-for-cni branch 2 times, most recently from 9e92abd to 2292260 Compare April 14, 2025 13:36
anmazzotti
anmazzotti previously approved these changes Apr 14, 2025
@Danil-Grigorev Danil-Grigorev force-pushed the use-fleet-for-cni branch 5 times, most recently from ae4993d to 6b2af14 Compare April 14, 2025 19:49
Copy link
Contributor

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks that CI is failing:

   Unexpected error:
      <template.ExecError>: 
      template: fleet-repo-template:12:9: executing "fleet-repo-template" at <.Revision>: can't evaluate field Revision in type framework.FleetCreateGitRepoInput
      {
          Name: "fleet-repo-template",
          Err: <*errors.errorString | 0xc000494ef0>{
              s: "template: fleet-repo-template:12:9: executing \"fleet-repo-template\" at <.Revision>: can't evaluate field Revision in type framework.FleetCreateGitRepoInput",
          },
      }

@Danil-Grigorev Danil-Grigorev force-pushed the use-fleet-for-cni branch 5 times, most recently from 345a632 to d90cb8e Compare April 15, 2025 10:22
@salasberryfin
Copy link
Contributor

I still think this may break nightly E2E tests. We should validate the workflow on this version, perhaps creating a new branch and running it from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Indicates an issue related to test kind/ci Issues or PRs related to CI workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E tests for Fleet bundle integration across all providers
5 participants