Skip to content

Conversation

@paleloser
Copy link
Collaborator

@paleloser paleloser commented May 26, 2025

This PR adds a new section for notifications:

image

Thanks to this section we will be able to notify the users about the status of ongoing tasks in the background without having to block the whole UI. Some examples are:

  • The installation of the workload is moved to the background and we notify the user when the installation is completed (with the respective status and action items)
  • If there are errors, we show them through this section: this way the notification is persisted for a given time, and the user decides whether to dismiss it or not

Notifications are stored in the extension backend, thus they won't dissappear between extension updates.

Comment on lines +90 to +97
const welcomeNotification: Notification = {
id: '-1',
title: 'Welcome to Application Collection extension!',
description: 'Go to https://docs.apps.rancher.io/ to learn how to get started.',
type: 'info',
dismissed: false,
timestamp: new Date().getTime()
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can decide whether to include this notification by default or not. This notification can help the user get started in case they don't have much context about the extension or the product.

It is true that right now there's not much content related to the extension in the documentation site. But it may help users to know about how to use some apps.

@paleloser
Copy link
Collaborator Author

❗ Merge after #29 and #27 to ensure the best integration between the features.

@paleloser paleloser added the feature New feature label May 28, 2025
@paleloser paleloser mentioned this pull request Jun 20, 2025
@paleloser paleloser marked this pull request as ready for review June 20, 2025 14:08
@paleloser paleloser requested a review from a team as a code owner June 20, 2025 14:08
@andresbono
Copy link
Contributor

Great feature 😍

Let me share a few small cases that I found a bit odd:

  • Now when you install the extension, it doesn't redirect you to "Settings" and the "Applications" view doesn't load because you have not set the credentials. Is it possible to keep redirecting to "Settings" at first? We could also include a quick note about the need of configuring your credentials specifically in the first notification.
  • When you click on VIEW DETAILS in a notification of an uninstalled workload, the extension breaks with an unexpected error.
  • When I forced an installation error (reinstalling Argo CD without cleaning the CRDs) the workload doesn't exist, so I can't see the details of the error.

@paleloser
Copy link
Collaborator Author

Very valuable feedback @andresbono , the last 3 commits should address your comments:

  • c8adb14 manages the workload details page when the workload does no longer exist
  • fa98817 changes the notification body in those cases where there's an error during the workload installation
  • 971e211 asks the user for authentication when it is not stored previously

@paleloser paleloser merged commit 048470f into main Jun 24, 2025
5 checks passed
@paleloser paleloser deleted the notifications-component branch June 24, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants