-
Notifications
You must be signed in to change notification settings - Fork 2
Workload details page #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…extension into workload-details-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
application-collection-extension/ui/src/pages/ApplicationDetailsPage/components/InstallDialog.tsx
Line 107 in 726456c
| <Typography variant='body1' sx={ { my: 2 } }>These are the application <Typography variant='code'>NOTES.txt</Typography>, read them carefully before closing this modal.</Typography> |
What if we lighten the message here now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea is that in #28 we're going to put the chart installation in the background (there are some charts that take a while to install, and we don't want to block the user activity). Through the notifications section we will inform the user about the installation progress. So I wouldn't invest more effort here. I'd put the focus in the other PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include the port mapping in the workload details page? As it is information that is already available in the workload card
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I've modified the view a bit and added the port mappings in 2c11ee0
| <Button | ||
| color='inherit' | ||
| onClick={ close } | ||
| disabled={ state === 'updating' }>Cancel</Button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm finding this button buggy.
- Click EDIT on the workload
- Click CANCEL.
⚠️ It doesn't close the modal and if you click outside the modal to close it, the extension becomes unresponsive.
Does it work for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a5f5378 should fix the button behavior 🤔
Adds a new page to inspect the workload details, which is particularly useful when:
NOTES.txtor any other workload data