Skip to content

Conversation

@paleloser
Copy link
Collaborator

Adds a new page to inspect the workload details, which is particularly useful when:

  • The workload update or installation failed: users can come to this page for more info.
  • If the user needs to review the NOTES.txt or any other workload data

image

image

@paleloser paleloser requested a review from a team as a code owner May 26, 2025 14:30
@paleloser paleloser mentioned this pull request May 26, 2025
@paleloser paleloser added the feature New feature label May 28, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Typography variant='body1' sx={ { my: 2 } }>These are the application <Typography variant='code'>NOTES.txt</Typography>, read them carefully before closing this modal.</Typography>

What if we lighten the message here now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is that in #28 we're going to put the chart installation in the background (there are some charts that take a while to install, and we don't want to block the user activity). Through the notifications section we will inform the user about the installation progress. So I wouldn't invest more effort here. I'd put the focus in the other PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include the port mapping in the workload details page? As it is information that is already available in the workload card

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I've modified the view a bit and added the port mappings in 2c11ee0

<Button
color='inherit'
onClick={ close }
disabled={ state === 'updating' }>Cancel</Button>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm finding this button buggy.

  • Click EDIT on the workload
  • Click CANCEL. ⚠️ It doesn't close the modal and if you click outside the modal to close it, the extension becomes unresponsive.

Does it work for you?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a5f5378 should fix the button behavior 🤔

@paleloser paleloser merged commit 0144423 into main Jun 20, 2025
5 checks passed
@paleloser paleloser deleted the workload-details-page branch June 20, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants