Increase file size precision in wheel check #18731
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
jakirkham
added
improvement
|
/ok to test |
|
/ok to test |
ci/validate_wheel.sh
Outdated
| @@ -12,6 +12,7 @@ rapids-logger "validate packages with 'pydistcheck'" | |||
|
|
|||
| pydistcheck \ | |||
| --inspect \ | |||
| --output-file-size-precision=4 \ | |||
There was a problem hiding this comment.
This appeared to be supported upstream
However am seeing the following error on CI:
Usage: pydistcheck [OPTIONS] [FILEPATHS]...
Try 'pydistcheck --help' for help.
Error: No such option: --output-file-size-precision
| # Default precision is 2. Bump this a bit for better visibility. | ||
| output_file_size_precision = 4 |
There was a problem hiding this comment.
Trying the config option instead
There was a problem hiding this comment.
Well that didn't work either.
Here is the error from CI:
ValueError: Configuration value 'output_file_size_precision' is not recognized by pydistcheck
|
Looks like the CI images pin Whereas the file size feature ( jameslamb/pydistcheck@802a9a8 ) wasn't added until To be able to use this check, we need to allow the new version to be installed in our CI images. Glancing through the history the pin was add as a safety measure (not due to a specific issue). So it seems reasonable to bump it. Doing so with PR: rapidsai/ci-imgs#269 |
|
/ok to test |
|
/ok to test |
Description
Checklist