Skip to content

Increase file size precision in wheel check #18731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: branch-25.06
Choose a base branch
from
Draft

Increase file size precision in wheel check #18731

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7ca66f0
Increase file size precision in wheel check
jakirkham May 9, 2025
f784c17
In `pyproject.toml` set `pydistcheck` precision
jakirkham May 9, 2025
a22027e
Merge branch 'branch-25.06' into inc_whl_file_size_prec_tst
jakirkham May 9, 2025
31a61d4
Merge branch 'branch-25.06' into inc_whl_file_size_prec_tst
jakirkham May 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/libcudf/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ libcudf = "libcudf"
select = [
"distro-too-large-compressed",
]

# Default precision is 2. Bump this a bit for better visibility.
output_file_size_precision = 4
Comment on lines +56 to +57
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying the config option instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that didn't work either.

Here is the error from CI:

ValueError: Configuration value 'output_file_size_precision' is not recognized by pydistcheck

# PyPI limit is 750 MiB, fail CI before we get too close to that
max_allowed_size_compressed = '675M'

Expand Down
Loading