Do not pretend to default initialize a device lambda #5015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found in CCCL CI
bdice
approved these changes
Apr 11, 2025
bdice
added
improvement
seunghwak
reviewed
Apr 11, 2025
| VertexValueInputIterator vertex_value_input_first{}; | ||
| VertexOp v_op{}; | ||
| vertex_t local_vertex_partition_range_first; | ||
| VertexValueInputIterator vertex_value_input_first; |
There was a problem hiding this comment.
Can't we default initialize iterators as well? Or is this because of possible thrust::transform_iterator with lambda?
There was a problem hiding this comment.
My reasoning with removing all default initializers is that partially initializing the struct does not make any sense and it is only ever initialized in a single place, so it feels "cleaner" to initialize all or nothing
Nothing I feel strongly about though
| vertex_t local_vertex_partition_range_first{}; | ||
| VertexValueInputIterator vertex_value_input_first{}; | ||
| VertexOp v_op{}; | ||
| vertex_t local_vertex_partition_range_first; |
There was a problem hiding this comment.
I think we can default initializing vertex_t (which is either int32_t or int64_t) or can this be also problematic?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in CCCL CI