Skip to content

Mark XGBoost tests as XFAIL #6516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Mark XGBoost tests as XFAIL #6516

wants to merge 2 commits into from

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Apr 7, 2025 •
edited
Loading

Same as #6515, but for the 25.04 branch.

@hcho3 hcho3 requested a review from a team as a code owner April 7, 2025 19:52
@hcho3 hcho3 requested review from teju85 and wphicks April 7, 2025 19:52
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Apr 7, 2025
@hcho3 hcho3 changed the title Temporarily skip all xgboost tests (backport) Mark XGBoost tests as XFAIL (backport) Apr 7, 2025
@csadorf csadorf mentioned this pull request Apr 7, 2025
Closed
@csadorf csadorf added bug Something isn't working non-breaking Non-breaking change ci labels Apr 7, 2025
@hcho3 hcho3 changed the title Mark XGBoost tests as XFAIL (backport) Mark XGBoost tests as XFAIL Apr 7, 2025
@csadorf
Copy link
Contributor

csadorf commented Apr 8, 2025

It might be sufficient to constrain the xgboost test dependency, see #6519 .

@trivialfis
Copy link
Member

I haven't been able to reproduce this error on my machine. Could you please hold until we are sure the CI configuration represents typical user installation?

@hcho3
Copy link
Contributor Author

hcho3 commented Apr 9, 2025

Superceded by #6519

@csadorf
Copy link
Contributor

csadorf commented Apr 9, 2025

I haven't been able to reproduce this error on my machine. Could you please hold until we are sure the CI configuration represents typical user installation?

Considering that the release is scheduled for tomorrow, I considered it prudent to take a very conservative approach. We can remove the constraint and potentially adjust the host configuration for branch-25.06.

@trivialfis
Copy link
Member

Got it, go ahead. ;-)

csadorf
csadorf requested changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this on branch-25.06, revert 2a8d33d, and make sure that the xfail reasons cites dmlc/xgboost#11397 ? Ideally we can xfail on the specific error and only for XGBoost 3.0.0.

@hcho3 hcho3 changed the base branch from branch-25.04 to branch-25.06 April 9, 2025 18:36
@github-actions github-actions bot removed the ci label Apr 9, 2025
@hcho3 hcho3 force-pushed the skip_xgb_tests_2504 branch from 1e8fc87 to 9581b0d Compare April 9, 2025 18:38
@hcho3
Copy link
Contributor Author

hcho3 commented Apr 9, 2025

@csadorf Done. I didn't revert 2a8d33d because that commit isn't yet part of the branch-25.06 branch.

@csadorf
Copy link
Contributor

csadorf commented Apr 11, 2025

The constraint is now merged into branch-25.06.

https://github.com/rapidsai/cuml/blob/branch-25.06/dependencies.yaml#L496

@csadorf
Copy link
Contributor

csadorf commented Apr 21, 2025

This was superseded by #6519 .

@csadorf csadorf closed this Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csadorf csadorf csadorf requested changes

@teju85 teju85 Awaiting requested review from teju85 teju85 is a code owner automatically assigned from rapidsai/cuml-python-codeowners

@wphicks wphicks Awaiting requested review from wphicks wphicks is a code owner automatically assigned from rapidsai/cuml-python-codeowners

Assignees

@hcho3 hcho3

Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hcho3 @csadorf @trivialfis