Skip to content

[FEA] HDBSCAN to Migrate to cuVS cluster prims from raft::cluster #6560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: branch-25.06
Choose a base branch
from
Open

[FEA] HDBSCAN to Migrate to cuVS cluster prims from raft::cluster #6560

wants to merge 12 commits into from

Conversation

tarang-jain
Copy link
Contributor

Depends on rapidsai/cuvs#820.

@tarang-jain tarang-jain requested review from a team as code owners April 18, 2025 23:08
@tarang-jain tarang-jain requested review from dantegd and bdice April 18, 2025 23:08
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Apr 18, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tarang-jain tarang-jain self-assigned this Apr 18, 2025
@tarang-jain
Copy link
Contributor Author

NB: CMake review is not required. The CMake change is temporary for testing (see comment in rapidsai/cuvs#820)

@tarang-jain tarang-jain mentioned this pull request Apr 18, 2025
Open
@tarang-jain tarang-jain added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 18, 2025
@tarang-jain
Copy link
Contributor Author

/ok to test

@divyegala divyegala mentioned this pull request Apr 18, 2025
Open
5 tasks
divyegala
divyegala reviewed Apr 21, 2025
View reviewed changes
@divyegala
Copy link
Member

/ok to test 44d404e

divyegala
divyegala approved these changes Apr 22, 2025
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI and revert

cpp/cmake/thirdparty/get_cuvs.cmake
Comment on lines +51 to +52
GIT_REPOSITORY https://github.com/tarang-jain/cuvs.git
GIT_TAG build-linkage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to revert

@tarang-jain tarang-jain removed the CMake label Apr 30, 2025
@github-actions github-actions bot added the CMake label Apr 30, 2025
viclafargue
viclafargue approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not deeply familiar with the algorithm. I didn’t notice any issues on my end.

@viclafargue
Copy link
Contributor

/ok to test 244a347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viclafargue viclafargue viclafargue approved these changes

@divyegala divyegala divyegala approved these changes

@dantegd dantegd Awaiting requested review from dantegd dantegd is a code owner automatically assigned from rapidsai/cuml-cmake-codeowners

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cuml-cmake-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@tarang-jain tarang-jain

Labels
CMake CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarang-jain @divyegala @viclafargue