Skip to content

Fetch rapids-cmake cmake-format with GitHub authentication - #2479

Open
bdice wants to merge 1 commit into
rapidsai:mainfrom
bdice:agent/check-style-gh-auth
Open

Fetch rapids-cmake cmake-format with GitHub authentication#2479
bdice wants to merge 1 commit into
rapidsai:mainfrom
bdice:agent/check-style-gh-auth

Conversation

@bdice

@bdice bdice commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Description

This is a fix for the style check download failure observed in #2476: https://github.com/rapidsai/rmm/actions/runs/28987611693/job/86020175188

--2026-07-09 01:29:50--  https://raw.githubusercontent.com/rapidsai/rapids-cmake/main/cmake-format-rapids-cmake.json
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 185.199.111.133, 185.199.108.133, 185.199.109.133, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|185.199.111.133|:443... connected.
HTTP request sent, awaiting response... 429 Too Many Requests
2026-07-09 01:29:53 ERROR 429: Too Many Requests.

This updates ci/check_style.sh to fetch cmake-format-rapids-cmake.json through the GitHub contents API with gh api when available. The existing unauthenticated wget download remains as the fallback.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice
bdice requested a review from a team as a code owner July 9, 2026 05:46
@bdice
bdice requested a review from KyleFromNVIDIA July 9, 2026 05:46
@bdice bdice added bug Something isn't working non-breaking Non-breaking change labels Jul 9, 2026
@bdice bdice self-assigned this Jul 9, 2026
@bdice bdice moved this to In Progress in RMM Project Board Jul 9, 2026
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d3aed3fa-f18e-45e5-8ff6-d4c25312b54c

📥 Commits

Reviewing files that changed from the base of the PR and between efea100 and 52830bc.

📒 Files selected for processing (1)
  • ci/check_style.sh

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the project copyright year range to 2026.
    • Improved file retrieval in the style check process by using a more reliable download method, with a fallback if the primary approach is unavailable.
    • Made path handling more robust when preparing temporary directories.

Walkthrough

The ci/check_style.sh script's SPDX copyright year was extended to 2020–2026. The cmake-format-rapids-cmake.json retrieval logic was changed to attempt download via gh api with specific headers, falling back to wget if gh is unavailable or fails, with directory creation now using a quoted dirname.

Changes

CI style check script update

Layer / File(s) Summary
cmake-format file retrieval with gh api fallback
ci/check_style.sh
Adds a gh api download path for the cmake-format JSON with required headers, falls back to wget when gh is unavailable or fails, quotes the dirname used for directory creation, and updates the SPDX copyright year to 2020–2026.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main CI change to fetch rapids-cmake formatting config with GitHub authentication.
Description check ✅ Passed The description matches the changeset and explains the style-check download fix and fallback behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@vyasr vyasr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, please make this change in cudf (and other repos with this fetch in place) too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants