Fetch rapids-cmake cmake-format with GitHub authentication - #2479
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ci/check_style.sh script's SPDX copyright year was extended to 2020–2026. The cmake-format-rapids-cmake.json retrieval logic was changed to attempt download via gh api with specific headers, falling back to wget if gh is unavailable or fails, with directory creation now using a quoted dirname. ChangesCI style check script update
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
vyasr
left a comment
There was a problem hiding this comment.
If you can, please make this change in cudf (and other repos with this fetch in place) too. Thanks!
Description
This is a fix for the style check download failure observed in #2476: https://github.com/rapidsai/rmm/actions/runs/28987611693/job/86020175188
This updates
ci/check_style.shto fetchcmake-format-rapids-cmake.jsonthrough the GitHub contents API withgh apiwhen available. The existing unauthenticatedwgetdownload remains as the fallback.Checklist