Share lib between ros1 and ros2 turtlesim #502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veerajsk
reviewed
Jun 26, 2023
supplementary/alica_ros1/alica_ros_turtlesim/etc/behaviours/GoTo.beh
Outdated
Show resolved
Hide resolved
supplementary/alica_ros2/alica_ros2_turtlesim/etc/behaviours/Teleport.beh
Show resolved
Hide resolved
Dale-Koenig
reviewed
Jul 21, 2023
supplementary/alica_ros_turtlesim/libalica-turtlesim/src/SpawnTurtle.cpp
Show resolved
Hide resolved
| @@ -0,0 +1,43 @@ | |||
| #include "WaitForTrigger.h" | |||
Contributor
There was a problem hiding this comment.
How is this different than WaitForMsg?
Collaborator
Author
There was a problem hiding this comment.
WaitForTrigger waits for an empty msg and then succeeds, WaitForMsg waits for a String msg, stores it on the blackboard and then succeeds. I removed it from the lib so we only have it in the ros1 / ros2 folders with their ros specific implementations
supplementary/alica_ros_turtlesim/libalica-turtlesim/src/WaitForMsg.cpp
Outdated
Show resolved
Hide resolved
…e interface base class
Closed
Dale-Koenig
reviewed
Aug 2, 2023
veerajsk
reviewed
Aug 10, 2023
supplementary/alica_ros_turtlesim/alica_turtlesim/CMakeLists.txt
Outdated
Show resolved
Hide resolved
supplementary/alica_ros_turtlesim/alica_turtlesim/include/alica_turtlesim/turtle_interfaces.hpp
Outdated
Show resolved
Hide resolved
supplementary/alica_ros_turtlesim/libalica-turtlesim/include/GoToCalculatedResult.h
Outdated
Show resolved
Hide resolved
supplementary/alica_ros_turtlesim/libalica-turtlesim/src/SpawnTurtle.cpp
Show resolved
Hide resolved
| setSuccess(); | ||
| } else { | ||
| Logging::logWarn("SpawnTurtle") << "Failed to spawn " << name << ". Succeeding anyway"; | ||
| setSuccess(); |
Contributor
There was a problem hiding this comment.
why do we set success here?
Collaborator
Author
There was a problem hiding this comment.
Usually when spawning a turtle fails the turtle is already spawned
rogeriofonteles
approved these changes
Aug 11, 2023
supplementary/alica_ros_turtlesim/alica_turtlesim/include/alica_turtlesim/turtle_interfaces.hpp
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share PML files and implementation for plans between ros1 and ros2 turtlesim. This PR only includes changes for ros1.
ros2 PR: #505