Skip to content

Improve software sync when frames are missing sync metadata #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidplowman merged 1 commit into from
Jan 7, 2026
Merged

Improve software sync when frames are missing sync metadata #891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion core/rpicam_encoder.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,14 @@ class RPiCamEncoder : public RPiCamApp
#ifndef DISABLE_RPI_FEATURES
// If sync was enabled, and SyncReady is still "false" then we must skip this frame. Tell our
// caller through the return value that we're not yet encoding anything.
if (GetOptions()->Get().sync && !completed_request->metadata.get(controls::rpi::SyncReady).value_or(false))
if (!sync_achieved_ &&
GetOptions()->Get().sync && !completed_request->metadata.get(controls::rpi::SyncReady).value_or(false))
return false;

// Setting this means that we won't skip frames that are missing sync metadata even though
// we had previously achieved sync. This could happen if the control algorithm doesn't run
// every frame.
sync_achieved_ = true;
#endif

StreamInfo info = GetStreamInfo(stream);
Expand Down Expand Up @@ -113,4 +119,5 @@ class RPiCamEncoder : public RPiCamApp
std::mutex encode_buffer_queue_mutex_;
EncodeOutputReadyCallback encode_output_ready_callback_;
MetadataReadyCallback metadata_ready_callback_;
bool sync_achieved_ = false;
};
Loading