[Dashboard] Fix dashboard for daylight savings #52755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did not get traction with the holistic fix for daylight savings as there was pushback on usage of tzlocal in python. So, splitting out the fix on the UI side which is perhaps less controversial. On the UI side, `timezone.ts` is showing GMT offsets not reflective of daylight savings time. Updating to dynamically pull the offset from `Intl.DateTimeFormat`. Note not doing any dynamic evaluation so for browser windows open during the switch, it will not update. Signed-off-by: Brendan Miller <[email protected]>
bhmiller
commented
May 2, 2025
bhmiller
force-pushed
the
fix-timezone-ui
branch
2 times, most recently
from
a219e89 to
5b01e1f
Compare
Node.js version used (14) does not seem to implement longOffset. Use shortOffset instead, and massage the output to be the same as longOffset. Signed-off-by: Brendan Miller <[email protected]>
8 tasks
alanwguo
reviewed
May 6, 2025
|
Thanks for the fix! |
longOffset vs. shortOffset doesn't matter. It's just for UI purposes, as formatUtils formatTimeZone takes the time zone names to derive the display, not offset. Also fixed match bug where for GMT+0, Intl.DateTimeFormat only prints "GMT", not e.g. "GMT+0". Signed-off-by: Brendan Miller <[email protected]>
masoudcharkhabi
added
usability
observability
alanwguo
approved these changes
May 14, 2025
|
Thanks for the contribution, merging! |
lk-chen
pushed a commit
to lk-chen/ray
that referenced
this pull request
May 17, 2025
Did not get traction with the [holistic fix](ray-project#51314) for daylight savings as there was pushback on usage of tzlocal in python. So, splitting out the fix on the UI side which is perhaps less controversial. On the UI side, `timezone.ts` is showing GMT offsets not reflective of daylight savings time. Updating to dynamically pull the offset from `Intl.DateTimeFormat`. Note not doing any dynamic evaluation so for browser windows open during the switch, it will not update. --------- Signed-off-by: Brendan Miller <[email protected]> Co-authored-by: Alan Guo <[email protected]>
vickytsang
pushed a commit
to ROCm/ray
that referenced
this pull request
Jun 3, 2025
Did not get traction with the [holistic fix](ray-project#51314) for daylight savings as there was pushback on usage of tzlocal in python. So, splitting out the fix on the UI side which is perhaps less controversial. On the UI side, `timezone.ts` is showing GMT offsets not reflective of daylight savings time. Updating to dynamically pull the offset from `Intl.DateTimeFormat`. Note not doing any dynamic evaluation so for browser windows open during the switch, it will not update. --------- Signed-off-by: Brendan Miller <[email protected]> Co-authored-by: Alan Guo <[email protected]> Signed-off-by: Vicky Tsang <[email protected]>
rebel-scottlee
pushed a commit
to rebellions-sw/ray
that referenced
this pull request
Jun 21, 2025
Did not get traction with the [holistic fix](ray-project#51314) for daylight savings as there was pushback on usage of tzlocal in python. So, splitting out the fix on the UI side which is perhaps less controversial. On the UI side, `timezone.ts` is showing GMT offsets not reflective of daylight savings time. Updating to dynamically pull the offset from `Intl.DateTimeFormat`. Note not doing any dynamic evaluation so for browser windows open during the switch, it will not update. --------- Signed-off-by: Brendan Miller <[email protected]> Co-authored-by: Alan Guo <[email protected]> Signed-off-by: Scott Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not get traction with the holistic fix for daylight savings as there was pushback on usage of tzlocal in python. So, splitting out the fix on the UI side which is perhaps less controversial.
On the UI side,
timezone.tsis showing GMT offsets not reflective of daylight savings time. Updating to dynamically pull the offset fromIntl.DateTimeFormat. Note not doing any dynamic evaluation so for browser windows open during the switch, it will not update.Why are these changes needed?
See #51310
Related issue number
Closes #51310
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.My tests are just running the typescript code through https://www.typescriptlang.org/play