[release test] move command_env getter into AnyscaleJobRunner#60272
Merged
aslonnie merged 1 commit intoray-project:masterfrom Jan 20, 2026
Merged
[release test] move command_env getter into AnyscaleJobRunner#60272aslonnie merged 1 commit intoray-project:masterfrom
aslonnie merged 1 commit intoray-project:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the way command environment variables are handled by moving the logic from the abstract base class CommandRunner to the concrete implementation AnyscaleJobRunner. This is a good change that improves the code structure by making the base class more abstract and placing implementation-specific details in the subclass. My review includes a suggestion to improve the type safety and robustness of the new get_full_command_env method.
so that it is not going back and force between the implementation and the abstract class, and not implemented as a property. Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
aslonnie
force-pushed
the
lonnie-260118-commandenv
branch
from
362a7f2 to
3e7b287
Compare
ray-gardener
bot
added
core
andrew-anyscale
approved these changes
Jan 20, 2026
jinbum-kim
pushed a commit
to jinbum-kim/ray
that referenced
this pull request
Jan 29, 2026
…oject#60272) so that it is not going back and forth between the implementation and the abstract class, and not implemented as a property. Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Signed-off-by: jinbum-kim <jinbum9958@gmail.com>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Feb 1, 2026
…oject#60272) so that it is not going back and forth between the implementation and the abstract class, and not implemented as a property. Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com> Signed-off-by: 400Ping <jiekaichang@apache.org>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Feb 3, 2026
…oject#60272) so that it is not going back and forth between the implementation and the abstract class, and not implemented as a property. Signed-off-by: Lonnie Liu <95255098+aslonnie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so that it is not going back and forth between the implementation and the abstract class, and not implemented as a property.