feat(wanda): Build dependencies in topological order

[andrew-anyscale]

Extend Build() to automatically build all dependencies before building the root spec. In local mode, specs are discovered by scanning the repo for *.wanda.yaml files and built in topological order. For a slight optimization, in RayCI mode, only the root spec is built (deps built by prior pipeline steps).

Topic: wanda-build-deps
Relative: wanda-deps

Signed-off-by: andrew andrew@anyscale.com

[andrew-anyscale]

Reviews in this chain:
└#348 feat(wanda): Build dependencies in topological order
　└#368 feat(wanda): Add 'params' field for env var validation and discovery

[andrew-anyscale]

#	head	base	diff	date	summary
0	e632ccc0	d7807b50	diff	Jan 6 9:33 AM	9 files changed, 119 insertions(+), 4 deletions(-)
1	f74ad642	470ff97d	rebase	Jan 6 9:41 AM	0 files changed
2	56e00c6d	6f660b11	rebase	Jan 6 9:45 AM	0 files changed
3	f3197048	c9aea31c	diff	Jan 6 9:49 AM	2 files changed, 16 insertions(+), 3 deletions(-)
4	ae47f277	c9aea31c	diff	Jan 6 9:50 AM	0 files changed
5	c1c2a3d1	c1346cb8	diff	Jan 9 17:19 PM	7 files changed, 70 insertions(+), 95 deletions(-)
6	9dc69db3	988af315	rebase	Jan 9 17:31 PM	0 files changed
7	05c0ded9	388c9c17	diff	Jan 12 14:09 PM	3 files changed, 17 insertions(+), 28 deletions(-)
8	839b0867	b822440f	rebase	Jan 12 17:22 PM	0 files changed
9	308598c1	587684f9	rebase	Jan 12 17:41 PM	0 files changed
10	e8c1f1b2	48b77597	rebase	Jan 12 17:49 PM	0 files changed
11	a8a69082	3d8245b0	rebase	Jan 12 18:07 PM	0 files changed
12	4d7b3449	698c6cb9	rebase	Jan 12 18:15 PM	0 files changed
13	b8380304	e8a41e21	diff	Jan 12 18:24 PM	1 file changed, 1 insertion(+), 1 deletion(-)
14	a289e514	853d062b	rebase	Jan 12 18:25 PM	0 files changed
15	2327511e	4c062ac3	diff	Jan 12 18:37 PM	1 file changed, 1 insertion(+), 1 deletion(-)
16	fdbd39ef	d437c29b	rebase	Jan 12 18:49 PM	0 files changed
17	86b1c2e1	d437c29b	diff	Jan 12 18:57 PM	2 files changed, 2 insertions(+), 2 deletions(-)
18	00b3ca37	d437c29b	diff	Jan 12 19:22 PM	1 file changed, 1 insertion(+), 1 deletion(-)
19	1a7af24d	835bb4c3	diff	Jan 13 8:30 AM	5 files changed, 15 insertions(+), 1 deletion(-)
20	b0597a44	9bd8415d	diff	Jan 13 8:45 AM	1 file changed, 1 insertion(+)
21	c0d07aea	2f656729	rebase	Jan 13 8:49 AM	0 files changed
22	e20bf2d1	3e32233e	rebase	Jan 13 9:32 AM	0 files changed
23	7c9b96c9	7bd90b70	diff	Jan 13 11:43 AM	2 files changed, 1 insertion(+), 2 deletions(-)
24	cd5a547a	8193927f	diff	Jan 13 11:51 AM	2 files changed, 13 insertions(+), 7 deletions(-)
25	987fd295	eb8860b9	diff	Jan 13 11:56 AM	0 files changed
26	543dfc49	7f955fda	diff	Jan 13 16:28 PM	1 file changed, 1 insertion(+), 1 deletion(-)
27	5a582a1d	7f955fda	diff	Jan 13 16:30 PM	2 files changed, 2 deletions(-)
28	35530d6d	7475e007	diff	Jan 13 16:48 PM	0 files changed
29	a384fdf6	7475e007	diff	Jan 13 17:23 PM	1 file changed, 15 insertions(+), 2 deletions(-)

[gemini-code-assist]

Summary of Changes

Hello @andrew-anyscale, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the wanda build system by introducing robust dependency resolution. It enables the CLI to automatically identify and build all required dependencies in the correct sequence, ensuring that complex multi-image projects can be built reliably and efficiently. This change streamlines the developer workflow, particularly for projects with intricate inter-image dependencies, while also providing an optimized path for CI/CD systems like RayCI.

Highlights

• Dependency Chain Building: Introduced a new BuildWithDeps function that automatically builds all dependencies in topological order before building the target specification.
• Image Tagging for Resolution: Ensures that each built image is tagged with its spec.Name, which is crucial for resolving @name references within the build system.
• CLI Integration: The wanda command-line interface has been updated to utilize the new BuildWithDeps function, while maintaining backward compatibility for existing workflows.
• RayCI Optimization: Implemented a conditional skip for dependency building when operating in RayCI mode, as these dependencies are assumed to be handled by prior pipeline steps.
• Comprehensive Testing: Added new test fixtures and dedicated tests to thoroughly validate the functionality of the dependency chain build process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces dependency chain builds to wanda by adding a BuildWithDeps function. The changes are well-structured and include corresponding tests for the new functionality. My review focuses on improving code clarity and test robustness. I've suggested a change to avoid mutating function arguments, which is a good practice for maintainability. I've also recommended strengthening a test case to ensure it properly verifies the expected outcome.