Skip to content

refactor(wanda): test cases and Dockerfiles for 'hello' variants#369

Merged
andrew-anyscale merged 1 commit intomainfrom
andrew/revup/main/wanda-refactor-hello
Jan 13, 2026
Merged

refactor(wanda): test cases and Dockerfiles for 'hello' variants#369
andrew-anyscale merged 1 commit intomainfrom
andrew/revup/main/wanda-refactor-hello

Conversation

@andrew-anyscale
Copy link
Contributor

Needed for subsequent work that will assume global uniqueness
between names

Topic: wanda-refactor-hello

Signed-off-by: andrew andrew@anyscale.com

Needed for subsequent work that will assume global uniqueness
between names

Topic: wanda-refactor-hello

Signed-off-by: andrew <andrew@anyscale.com>
@andrew-anyscale
Copy link
Contributor Author

Reviews in this chain:
#369 refactor(wanda): test cases and Dockerfiles for 'hello' variants
 └#347 feat(wanda): Add dependency resolution for wanda specs
  └#348 feat(wanda): Build dependencies in topological order
   └#368 feat(wanda): Add 'params' field for env var validation and discovery

@andrew-anyscale
Copy link
Contributor Author

# head base diff date summary
0 ebed2021 1f056c13 diff Jan 13 8:30 AM 6 files changed, 15 insertions(+), 15 deletions(-)

@gitar-bot
Copy link

gitar-bot bot commented Jan 13, 2026

Code Review ✅ Approved

Clean refactor that renames test fixtures to ensure globally unique names. All references updated consistently across test files and configurations.

Options

Auto-apply is off Gitar will not commit updates to this branch.
Display: compact Hiding non-applicable rules.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)

@andrew-anyscale andrew-anyscale merged commit f547b3c into main Jan 13, 2026
2 checks passed
@andrew-anyscale andrew-anyscale deleted the andrew/revup/main/wanda-refactor-hello branch January 13, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants