This repository was archived by the owner on Jan 12, 2026. It is now read-only.
Open
Conversation
Contributor
Author
|
I verified the change works with the blow code example: |
|
@Yard1 can you help take a look when you get a chance? thanks! |
heyitsmui
reviewed
Oct 2, 2023
| def get_column( | ||
| cls, data: pd.DataFrame, column: Any | ||
| ) -> Tuple[pd.Series, Optional[str]]: | ||
| ) -> Tuple[pd.Series, Optional[Union[str, List]]]: |
There was a problem hiding this comment.
should we open up a separate get_columns(...) instead of overloading this method?
Yard1
approved these changes
Oct 2, 2023
Yard1
reviewed
Oct 12, 2023
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Yard1
reviewed
Oct 13, 2023
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
Contributor
Author
|
Hi @Yard1 may I ask how to fix the lint test? Seems it still blocks the merge. Thank you! |
Member
|
Can you run the ./format.sh script in the root of the repo? |
|
@louis-huang can you please run the above test please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi I added support to allow label as a list. So we can support reading data with multiple labels. This can then solve #286.
I verified new unit tests pass. Also test_matrix.py all pass with my local set up.
I verified locally by training a xgboost model with parquet data format, it works well. So far it should work well for parquet data format. Thank you!