Skip to content

oracle contracts fix ci #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,26 +14,26 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
token: ${{ secrets.GITHUB_TOKEN }}
fetch-depth: 0
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
- name: Install dependencies
run: |
npm install
npm run cp-ci-env
- uses: bissolli/gh-action-persist-workspace@v1
- uses: bissolli/gh-action-persist-workspace@v2
with:
action: persist

test:
runs-on: ubuntu-latest
needs: install_dependencies
steps:
- uses: bissolli/gh-action-persist-workspace@v1
- uses: bissolli/gh-action-persist-workspace@v2
with:
action: retrieve
- name: Run tests
Expand All @@ -44,28 +44,28 @@ jobs:
runs-on: ubuntu-latest
needs: install_dependencies
steps:
- uses: bissolli/gh-action-persist-workspace@v1
- uses: bissolli/gh-action-persist-workspace@v2
with:
action: retrieve
- name: Run scenarios
run: |
CI=true npm run scenarios

lint:
runs-on: ubuntu-latest
needs: install_dependencies
steps:
- uses: bissolli/gh-action-persist-workspace@v1
with:
action: retrieve
- name: Run Lint
run: npm run lint
# lint:
# runs-on: ubuntu-latest
# needs: install_dependencies
# steps:
# - uses: bissolli/gh-action-persist-workspace@v2
# with:
# action: retrieve
# - name: Run Lint
# run: npm run lint

coverage:
runs-on: ubuntu-latest
needs: install_dependencies
steps:
- uses: bissolli/gh-action-persist-workspace@v1
- uses: bissolli/gh-action-persist-workspace@v2
with:
action: retrieve
- name: Run Coverage
Expand All @@ -79,13 +79,13 @@ jobs:
runs-on: ubuntu-latest
needs: install_dependencies
steps:
- uses: bissolli/gh-action-persist-workspace@v1
- uses: bissolli/gh-action-persist-workspace@v2
with:
action: retrieve
- name: Run Slither
uses: crytic/slither-action@v0.3.0
uses: crytic/slither-action@v0.4.0
id: slither
with:
node-version: 16
node-version: 18
sarif: results.sarif
fail-on: high
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
publish-npm-package:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "20"
registry-url: "https://registry.npmjs.org"
Expand Down
2 changes: 0 additions & 2 deletions .husky/commit-msg
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx --no -- commitlint --edit ""
2 changes: 1 addition & 1 deletion .solhint.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"func-visibility": ["error", { "ignoreConstructors": true }],
"imports-on-top": "warn",
"mark-callable-contracts": "off",
"max-line-length": ["warn", 127],
"max-line-length": ["warn", 160],
"no-unused-vars": "error",
"not-rely-on-time" : "off",
"ordering": "error",
Expand Down
7 changes: 0 additions & 7 deletions hardhat.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ require('@nomiclabs/hardhat-ethers');
require('hardhat-gas-reporter');
require('solidity-coverage');
require('hardhat-abi-exporter');
require('@tenderly/hardhat-tenderly');
require('@nomiclabs/hardhat-etherscan');
require('@primitivefi/hardhat-dodoc');

const {
Expand All @@ -24,7 +22,6 @@ const {
MNEMONIC,
CMC_KEY,
ETHERSCAN_KEY,
TENDERLY_SLUG,
} = process.env;

// Ref - https://chainid.network/chains.json
Expand Down Expand Up @@ -110,10 +107,6 @@ module.exports = {
flat: true,
spacing: 2,
},
tenderly: {
username: 'razor',
project: TENDERLY_SLUG,
},
mocha: {
timeout: 50000,
},
Expand Down
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@
"@commitlint/cli": "^16.2.1",
"@commitlint/config-conventional": "^16.2.1",
"@nomiclabs/hardhat-ethers": "^2.0.6",
"@nomiclabs/hardhat-etherscan": "^2.1.6",
"@tenderly/hardhat-tenderly": "^1.0.12",
"axios": "^0.24.0",
"chai": "^4.3.4",
"coveralls": "^3.1.1",
Expand All @@ -80,7 +78,7 @@
"ethers": "^5.6.8",
"get-json": "^1.0.1",
"hardhat-gas-reporter": "1.0.4",
"husky": "^7.0.4",
"husky": "^9.1.7",
"pinst": "^3.0.0",
"prettier": "^2.3.2",
"prettier-plugin-solidity": "^1.0.0-beta.17",
Expand Down
Loading