-
Notifications
You must be signed in to change notification settings - Fork 197
fix: blade theme and neutral button #3910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3be5f12
fix: updates storybook theme & adds the button black variant
rohankokane 6b12402
chore: interactive story
rohankokane eba1643
fix: focus ring transition
rohankokane b3d62a0
Merge branch 'master' into fix/blade-svelte-theme
rohankokane-dev 9149a1e
fix: change color to neutral
rohankokane dc88e95
chore: adds changeset
rohankokane f94cded
Merge branch 'master' into fix/blade-svelte-theme
rohankokane 837646c
Merge branch 'master' into fix/blade-svelte-theme
rohankokane c6439bf
fix: button neutral tokens
rohankokane b6c0f9a
chore: apply requested changes via autonomous agent
895b626
Merge branch 'master' into fix/blade-svelte-theme
rohankokane-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| '@razorpay/blade-core': minor | ||
| '@razorpay/blade-svelte': minor | ||
| --- | ||
|
|
||
| feat: add `black` color variant to Button | ||
|
|
||
| fix: focus-ring transition and offset flash on inputs | ||
|
|
||
| fix: use `bladeTheme` as default Storybook theme in blade-svelte |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
...ages/blade-svelte/src/components/BladeProvider/InteractiveTokensPlayground.stories.svelte
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <script module lang="ts"> | ||
| import { defineMeta } from '@storybook/addon-svelte-csf'; | ||
| import InteractiveTokensPlayground from './InteractiveTokensPlayground.svelte'; | ||
|
|
||
| const { Story } = defineMeta({ | ||
| title: 'Playground/Interactive Tokens', | ||
| component: InteractiveTokensPlayground, | ||
| tags: ['autodocs'], | ||
| parameters: { | ||
| layout: 'fullscreen', | ||
| docs: { | ||
| description: { | ||
| component: | ||
| "Every Blade Svelte component that consumes `interactive.*` color tokens, rendered together. Pick a brand color to run it through Blade's real `createTheme` pipeline and feed `BladeProvider` — exactly like a themed app. The full `interactive.primary.*` state scale is derived by `createTheme` (positive / negative / notice / neutral / gray / static* are fixed Blade tokens with no app-facing override).", | ||
| }, | ||
| }, | ||
| }, | ||
| }); | ||
| </script> | ||
|
|
||
| <!-- Self-contained playground: owns its own BladeProvider, so the global decorator is skipped. --> | ||
| <Story | ||
| name="Playground" | ||
| asChild | ||
| parameters={{ | ||
| controls: { disable: true }, | ||
| skipBladeProviderDecorator: true, | ||
| }} | ||
| > | ||
| <InteractiveTokensPlayground /> | ||
| </Story> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 [MAJOR] · code-quality-critique · confidence: 8/10
Problem: Neutral primary background token mismatch: getButtonBackgroundColorToken returns
interactive.${property}.staticBlack.${_state}but the CSS .color-neutral class uses--interactive-background-neutral-*tokens. The disabled state values differ — staticBlack.disabled is hsla(0,0%,0%,0.56) while neutral.disabled is hsla(0,0%,0%,0.18). Since getButtonProgressRestColorToken calls this function with state:'disabled', the definite-loading rest cover paints at 0.56 opacity black instead of matching the actual disabled appearance at 0.18 opacity.Suggestion: Change
staticBlacktoneutralin the neutral primary return:returninteractive.${property}.neutral.${_state};— this aligns the token with the CSS .color-neutral variables and fixes the loading rest color.