fix(tokens): drop the needs-attention suffix from the token push PR title - #3929
Merged
Conversation
…itle A token push that could not verify itself titled its PR 'feat(tokens): update tokens from figma (needs attention)'. The suffix outlives the problem: draft state and the blocking section in the body both clear themselves as the PR is fixed and marked ready, but the title has to be edited by hand, and this repo squash-merges with the PR title as the commit message. Miss the cleanup and '(needs attention)' lands on master permanently, as very nearly happened on #3925. Draft state already carries the signal, and the reasons stay in the body. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
saurav12
requested review from
anuraghazra,
kamleshchandnani,
ravikumar-rajagopalan,
rohankokane-dev,
saurabhdaware and
swapnil-kr1
as code owners
August 26, 2026 14:55
|
Contributor
|
🤖 Slash AI Review has been triggered. View execution logs |
Collaborator
🛡️ Coverage ReportSummaryFull Coverage Details |
![rzp-slash[bot]](https://avatars.githubusercontent.com/u/7713209?s=60&v=4){kind=small}
swapnil-kr1
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3919.
A token push that could not verify itself titled its PR
feat(tokens): update tokens from figma (needs attention). That marker outlives the problem it describes:This repo squash-merges with the PR title as the commit message, so a missed cleanup puts
(needs attention)on master permanently. That nearly happened on #3925 — the blocker was fixed and the PR marked ready with the suffix still in the title.The title is now constant. Draft state carries the signal, the reasons stay in the body, and both resolve themselves as the PR is fixed.
No behaviour change beyond the title:
--draftis still driven byblockers.length, and the body is unchanged.Verification
packages/blade/src/tokensround-trips byte-identicalTooling only —
packages/blade/scripts/is not in the publishedfileslist, so no changeset.🤖 Generated with Claude Code