RDKEMW-10671 : Intermittent failure on Testframework while running entservices-softwareupdate workflows. #183
Conversation
Update to latest commit
Update to latest commit
Reduced sleep duration in stopMaintenance and startMaintenance tests from 5 seconds to 2 seconds.
Removed GDB logging and additional debug info capture from unit test workflow.
Update to latest commit
Update to latest commit
…services-softwareupdate into feature/L1-L2test
…services-softwareupdate into feature/L1-L2test
…services-softwareupdate into feature/L1-L2test
There was a problem hiding this comment.
Pull request overview
This PR modifies test infrastructure and test cases for the MaintenanceManager component. The primary purpose appears to be testing workflow configurations while improving test reliability through better synchronization logic.
Key changes:
- Added retry logic with timeout to ensure maintenance has started before attempting to stop it in the
stopMaintenancetest - Restructured the
getMaintenanceStartTime_json_rpctest to better separate file verification from test assertions - Modified the GitHub Actions workflow to use a test branch instead of the develop branch
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| Tests/L2Tests/tests/MaintenancemanagerL2.cpp | Refactored test structure to add polling/retry logic for maintenance status verification and cleaned up file verification code |
| .github/workflows/L2-tests.yml | Changed repository reference from 'develop' to 'Test_Workflow' branch for testing purposes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| repository: rdkcentral/entservices-softwareupdate | ||
| path: entservices-softwareupdate | ||
| ref: develop | ||
| ref: Test_Workflow |
There was a problem hiding this comment.
The workflow is being changed to use a test branch 'Test_Workflow' instead of 'develop'. This appears to be a temporary change for testing purposes and should likely not be merged to the main branch. Using a test branch reference in the workflow configuration could cause CI/CD failures once the test branch is removed or if the branch doesn't exist in production environments.
| ref: Test_Workflow | |
| ref: develop |
| std::ifstream verifyFile("/opt/rdk_maintenance.conf"); | ||
| if (!verifyFile) { | ||
| std::cerr << "Failed to open /opt/rdk_maintenance.conf for reading." << std::endl; | ||
| } else { | ||
| std::string line; | ||
| while (std::getline(MaintenanceManagerConfFile, line)) { | ||
| while (std::getline(verifyFile, line)) { | ||
| std::cout << line << std::endl; | ||
| } | ||
| verifyFile.close(); | ||
| } |
There was a problem hiding this comment.
The verification code reads and prints the configuration file content to stdout, but there are no assertions to verify that the file was written correctly or contains the expected content. This debug output provides limited value in automated tests and makes test output more verbose. Consider either adding assertions to verify the file content or removing this verification block if it's not necessary for the test.
…neration when the caller source is Testframework
smanes0213
changed the title
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…must build every time
…rs to prevent duplicate definitions
…ld needing Communicator mock
…nly in testframework
Reason for change: Resolve intermittent failures while running tests on testframework repo
Test Procedure: Run L1, L2, L2-OOP(If applicable)
Risks: Low
Priority: P0
Version:minor